Data loading #16
Data loading #16
Conversation
ksew1
force-pushed
the
data-loading
branch
2 times, most recently
from
77dca6b to
5afee18
Compare
| const PROFILER_NAMESPACE: &str = "github.com/software-mansion/cairo-profiler"; | ||
| const COVERAGE_NAMESPACE: &str = "github.com/software-mansion/cairo-coverage"; | ||
|
|
||
| type FileLocation = String; |
There was a problem hiding this comment.
Should be a path.
There was a problem hiding this comment.
But we also have items like this:
/Users/makysmiliandemitraszek/Library/Caches/com.swmansion.scarb/registry/std/e512d6dd1/core/src/lib.cairo[array_inline_macro]
which is not really a path.
| } | ||
|
|
||
| #[derive(Deserialize, Clone, Debug, Eq, PartialEq)] | ||
| pub struct Range { |
There was a problem hiding this comment.
Not informative name.
| // Safe to unwrap because we ensured that the keys are the same | ||
| let function_names = statements_functions.get(&key).unwrap().to_owned(); |
There was a problem hiding this comment.
I think it is better to do it in a safe way. You don't have to hold the pre-conditions in your head this way and you don't have to trust your preconditions are correct. This is a very good feature of the language, there is no point of throwing it away unless necessary.
There was a problem hiding this comment.
I believe this could be written succinctly as
collect should handle this for you
let statement_map: Result<Map<...>> = statements_code_locations
.into_iter()
.map(|(key, code_locations)| {
// Safe to unwrap because we ensured that the keys are the same
let Some(function_names) = statements_functions.get(&key).unwrap().to_owned();
Ok((
key,
StatementDetails {
code_locations,
function_names,
},
))
} else {
Error("msg")
}
)
.collect();
| #[allow(dead_code)] // Temporary | ||
| pub fn new( | ||
| call_trace_path: &Utf8PathBuf, | ||
| versioned_program_path: &Utf8PathBuf, |
There was a problem hiding this comment.
Why is versioned_program_path a parameter here? Shouldn't we rather take this information from call_trace -> cairo_execution_info -> source_sierra_path?
There was a problem hiding this comment.
It seems that this is the same file as test_project_Tests.sierra.json. If that's the case can we avoid duplicating this file?
Data loading
Closes #9