chore(apple): fix build issues caught internally #2629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At my side of Microsoft, we have recently "vendored" a couple of libraries. Which means, we started building them from source using our own generated Xcode project (not the one cocoa pods generates), which has much stricter build flags / treats warnings as errors. In doing so, I caught a couple of issues in React Native SVG I'd like to push back up!
Namely:
__unused
clang pragmas in a couple of placesCF_ENUM
toNS_ENUM
, and include an import of<Foundation.h
><Foo.h>
) to User Header Search Paths ("foo.h"
)RNSVGFontData
to fix a "Declaration shadows a local variable" (I guess self is always in scope?)<TargetConditionals.h>
in places where we use#if TARGET_OS_OSX
ifdefsRNSVGTopAlignedLabel
label
object from declared in a random spot in the file (??!) to be a properivar
... this one was fun to catch.kCGImageAlphaPremultipliedLast | kCGBitmapByteOrder32Big;
to a separate variable. Technically, those two types are actually values from two different enums, but they are meant to be used together and cast, so 🤷♂️Test Plan
CI should pass at the very least
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
__tests__
folder