Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OboeSettings.type and .layer #8

Merged
merged 3 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@ Represents oboe setting message

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| type | [OboeSettingType](#collector-OboeSettingType) | | oboe setting type struct, always DEFAULT_SAMPLE_RATE |
| type | [OboeSettingType](#collector-OboeSettingType) | | **Deprecated.** oboe setting type struct, always DEFAULT_SAMPLE_RATE |
| flags | [bytes](#bytes) | | flags where { OK=0x0, INVALID=0x1, OVERRIDE=0x2, SAMPLE_START=0x4, SAMPLE_THROUGH=0x8, SAMPLE_THROUGH_ALWAYS=0x10, TRIGGERED_TRACE=0x20 }. e.g. 54 means OK or OVERRIDE or SAMPLE_START or SAMPLE_THROUGH_ALWAYS or TRIGGERED_TRACE |
| timestamp | [int64](#int64) | | Epoch timestamp |
| value | [int64](#int64) | | Sampling rate, 1000000 means 100% |
| layer | [bytes](#bytes) | | layer name, not set since type is always DEFAULT_SAMPLE_RATE |
| layer | [bytes](#bytes) | | **Deprecated.** layer name, not set since type is always DEFAULT_SAMPLE_RATE |
| arguments | [OboeSetting.ArgumentsEntry](#collector-OboeSetting-ArgumentsEntry) | repeated | key-value pairs. Keys can be [`BucketCapacity`, `BucketRate`, `TriggerRelaxedBucketCapacity`, `TriggerRelaxedBucketRate`, `TriggerStrictBucketCapacity`, `TriggerStrictBucketRate`, `SignatureKey`] |
| ttl | [int64](#int64) | | time to live for this setting struct |
| ttl | [int64](#int64) | | time to live for this setting struct, in seconds |



Expand Down
6 changes: 3 additions & 3 deletions collector.proto
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,13 @@ enum OboeSettingType {
* Represents oboe setting message
*/
message OboeSetting {
OboeSettingType type = 1; // oboe setting type struct, always DEFAULT_SAMPLE_RATE
OboeSettingType type = 1 [deprecated = true]; // oboe setting type struct, always DEFAULT_SAMPLE_RATE
bytes flags = 2; // flags where { OK=0x0, INVALID=0x1, OVERRIDE=0x2, SAMPLE_START=0x4, SAMPLE_THROUGH=0x8, SAMPLE_THROUGH_ALWAYS=0x10, TRIGGERED_TRACE=0x20 }. e.g. 54 means OK or OVERRIDE or SAMPLE_START or SAMPLE_THROUGH_ALWAYS or TRIGGERED_TRACE
int64 timestamp = 3; // Epoch timestamp
int64 value = 4; // Sampling rate, 1000000 means 100%
bytes layer = 5; // layer name, not set since type is always DEFAULT_SAMPLE_RATE
bytes layer = 5 [deprecated = true]; // layer name, not set since type is always DEFAULT_SAMPLE_RATE
map<string, bytes> arguments = 7; // key-value pairs. Keys can be [`BucketCapacity`, `BucketRate`, `TriggerRelaxedBucketCapacity`, `TriggerRelaxedBucketRate`, `TriggerStrictBucketCapacity`, `TriggerStrictBucketRate`, `SignatureKey`]
int64 ttl = 8; // time to live for this setting struct
int64 ttl = 8; // time to live for this setting struct, in seconds
}

/**
Expand Down
90 changes: 45 additions & 45 deletions cpp/collector.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions cpp/collector.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading