Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-97751 otel.status_code, otel.status_description at APM-proto span export #470

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Dec 23, 2024

Updates our custom, non-OTLP exporter to add otel.status_code, otel.status_description attributes before export, based on SDK-set span status values.

tests/unit/test_exporter.py Fixed Show fixed Hide fixed
tests/unit/test_exporter.py Fixed Show fixed Hide fixed
tests/unit/test_exporter.py Fixed Show fixed Hide fixed
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review December 24, 2024 00:48
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner December 24, 2024 00:48
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tammy-baylis-swi!

@tammy-baylis-swi tammy-baylis-swi merged commit 8676416 into main Jan 2, 2025
17 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-97751-apm-proto-addinfo-span-status branch January 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants