Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: disable performance tests #10535

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

sam-heilbron
Copy link

@sam-heilbron sam-heilbron commented Dec 24, 2024

Description

Disable performance tests from running during nightly tests

Context

nightly tests have been failing for weeks/months, due to out of space issues

Latest logs: https://github.com/solo-io/gloo/actions/runs/12477212932/job/34823088427

# github.com/solo-io/gloo/test/services.test
/opt/hostedtoolcache/go/1.23.3/x64/pkg/tool/linux_amd64/link: mapping output file failed: no space left on device

I created #10534 to track the future work

Interesting decisions

Testing steps

  • I used this branch to kick off a nightly run, and observed that performance tests are skipped:

Logs: https://github.com/solo-io/gloo/actions/runs/12483728605

This job was skipped

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sam-heilbron
Copy link
Author

sam-heilbron commented Dec 24, 2024

/skip-ci non-functional change, again 3

@npolshakova npolshakova mentioned this pull request Dec 24, 2024
4 tasks
@sam-heilbron sam-heilbron requested a review from nfuden December 24, 2024 17:27
Copy link
Collaborator

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@soloio-bulldozer soloio-bulldozer bot merged commit 599a44e into main Dec 27, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/disable-performance-tests branch December 27, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants