gateway2: allow route delegation using well known label #10561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
shashankram
changed the title
|
Visit the preview URL for this PR (updated for commit 24b6099): https://gloo-edge--pr10561-shashankram-deleg-la-p5mpuwbn.web.app (expires Fri, 17 Jan 2025 16:02:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
yuval-k
reviewed
Jan 9, 2025
There is a product requirement to enable users to use a label to select HTTPRoutes to delegate to instead of GVK ref to other HTTPRoutes (includes wildcards). To strike a balance between flexibility and performance, this change implements the proposal to use a well known label `delegation.gateway.solo.io/label=<value>` to allow users to delegate to other HTTPRoutes using a label. HTTPRoutes are indexed using this well known label key that enable O(1) lookups of routes matching this label value. Also moves user-facing labels and annotations to the wellknown pkg to consolidate them for visibility. Signed-off-by: Shashank Ram <[email protected]>
shashankram
force-pushed
the
shashankram/deleg-label
branch
from
da9989a to
24b6099
Compare
yuval-k
approved these changes
Jan 10, 2025
stevenctl
approved these changes
Jan 10, 2025
shashankram
added a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Shashank Ram <[email protected]>
shashankram
added a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Shashank Ram <[email protected]>
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
…10561) (#10567) Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a product requirement to enable users to use a label to select HTTPRoutes to delegate to instead of GVK ref to other HTTPRoutes (includes wildcards).
To strike a balance between flexibility and performance, this change implements the proposal to use a well known label
delegation.gateway.solo.io/label=<value>to allow users to delegate to other HTTPRoutes using a label. HTTPRoutes are indexed using this well known label key that enable O(1) lookups of routes matching this label value.API changes
New
delegation.gateway.solo.io/labellabel to select HTTPRoutes to delegate to.Checklist:
TODO