Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS for xDS with Gloo Gateway docs #10588

Closed
wants to merge 5 commits into from
Closed

Conversation

sheidkamp
Copy link

@sheidkamp sheidkamp commented Jan 30, 2025

Description

Update "Gloo Gateway mTLS mode" doc to reflect expansion of functionality to Kubernetes Gateway.

Code changes

Addressed nit, changing os.Getenv("GLOO_MTLS_SDS_ENABLED") == "true" to envutils.IsTruthyValue("GLOO_MTLS_SDS_ENABLED")

Docs changes

Update "Gloo Gateway mTLS mode" doc to reflect expansion of functionality to Kubernetes Gateway.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sheidkamp sheidkamp requested a review from a team as a code owner January 30, 2025 18:42
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6210

This feature was introduced in version 1.3.6 of Gloo Gateway and version 1.3.0-beta3 of Gloo Gateway Enterprise. If you are using earlier versions of Gloo Gateway, this feature will not be available.
This feature was introduced in version 1.3.6 of Gloo Gateway and version 1.3.0-beta3 of Gloo Gateway Enterprise. If you are using earlier versions of Gloo Gateway, this feature will not be available
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version is so old we should probably just remove this message

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, removed

docs/content/guides/security/tls/mtls/_index.md Outdated Show resolved Hide resolved
projects/gateway2/setup/ggv2setup.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 30, 2025

Visit the preview URL for this PR (updated for commit 01ded8f):

https://gloo-edge--pr10588-sheidkamp-k8s-gw-mtl-qteamk1p.web.app

(expires Thu, 06 Feb 2025 19:37:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@sheidkamp
Copy link
Author

Labelling as "work in progress" until the docs team is able to review

sheidkamp and others added 2 commits January 30, 2025 14:26
@sheidkamp
Copy link
Author

Wrong repo for these docs, changes will get added to appropriate location with https://github.com/solo-io/docs/issues/492

@sheidkamp sheidkamp closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants