-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS for xDS with Gloo Gateway docs #10588
Conversation
Issues linked to changelog: |
This feature was introduced in version 1.3.6 of Gloo Gateway and version 1.3.0-beta3 of Gloo Gateway Enterprise. If you are using earlier versions of Gloo Gateway, this feature will not be available. | ||
This feature was introduced in version 1.3.6 of Gloo Gateway and version 1.3.0-beta3 of Gloo Gateway Enterprise. If you are using earlier versions of Gloo Gateway, this feature will not be available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version is so old we should probably just remove this message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, removed
Visit the preview URL for this PR (updated for commit 01ded8f): https://gloo-edge--pr10588-sheidkamp-k8s-gw-mtl-qteamk1p.web.app (expires Thu, 06 Feb 2025 19:37:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Labelling as "work in progress" until the docs team is able to review |
Co-authored-by: Andy Fong <[email protected]> Co-authored-by: Jenny Shu <[email protected]>
Wrong repo for these docs, changes will get added to appropriate location with https://github.com/solo-io/docs/issues/492 |
Description
Update "Gloo Gateway mTLS mode" doc to reflect expansion of functionality to Kubernetes Gateway.
Code changes
Addressed nit, changing
os.Getenv("GLOO_MTLS_SDS_ENABLED") == "true"
toenvutils.IsTruthyValue("GLOO_MTLS_SDS_ENABLED")
Docs changes
Update "Gloo Gateway mTLS mode" doc to reflect expansion of functionality to Kubernetes Gateway.
Checklist: