Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce nooneway test failures #10599

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ryanrolds
Copy link

@ryanrolds ryanrolds commented Feb 7, 2025

Description

Was able to reproduce locally. After looking at the logs and things, it appears things were getting to a working state but just not fast enough for the test. Adjusting the timeout. I was able to confirm that I no longer saw the test fail locally with 2m.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@ryanrolds
Copy link
Author

/kick-ci

@ryanrolds ryanrolds marked this pull request as ready for review February 7, 2025 17:05
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7685

@ryanrolds ryanrolds changed the title Rolds/improve nooneway tls test Reduce nooneway test failures Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Visit the preview URL for this PR (updated for commit 7c6294a):

https://gloo-edge--pr10599-rolds-improve-noonew-e49sfiba.web.app

(expires Fri, 14 Feb 2025 22:56:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant