-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Qt version #170
Align Qt version #170
Conversation
@xingularity could you please help review the PR? |
We have recently upgraded the Qt version to 6.8.1, could you change the version to 6.8.1? |
Surely, I can do this. |
@xingularity Could you please help me review the PR? thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonwu0919 could you please do a rebase to remove the unnecessary merge in the PR for this simple patch?
0a86a58
to
3345c2b
Compare
in scripts/build/qt, I change line 44 from `pkgbranch=${VERSION:-6.5.3}` to ` pkgbranch=${VERSION:-6.8.1}`.
3345c2b
to
1e2f5e0
Compare
Thank for the reminding. I forgot to squash the redundant commits. @yungyuc could you help me review the result? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonwu0919 could you please do a rebase to remove the unnecessary merge in the PR for this simple patch?
Thank for the reminding. I forgot to squash the redundant commits.
@yungyuc could you help me review the result? Thank you.
LGTM
This PR updates the default Qt version in the build script to 6.6.3. Specifically, line 44 of the file scripts/build.d/qt was modified from:
pkgbranch=${VERSION:-6.5.3}
topkgbranch=${VERSION:-6.6.3}
.Please note that while this change updates the version reference, further testing for potential side effects of this update has not yet been conducted. I will perform testing once my new SSD arrives next week, as my current system is out of storage for building a virtual machine.
Related to #169