Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Qt version #170

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Align Qt version #170

merged 1 commit into from
Jan 13, 2025

Conversation

dragonwu0919
Copy link
Contributor

@dragonwu0919 dragonwu0919 commented Sep 13, 2024

This PR updates the default Qt version in the build script to 6.6.3. Specifically, line 44 of the file scripts/build.d/qt was modified from: pkgbranch=${VERSION:-6.5.3} to pkgbranch=${VERSION:-6.6.3}.

Please note that while this change updates the version reference, further testing for potential side effects of this update has not yet been conducted. I will perform testing once my new SSD arrives next week, as my current system is out of storage for building a virtual machine.

Related to #169

@yungyuc
Copy link
Member

yungyuc commented Sep 13, 2024

@xingularity could you please help review the PR?

@xingularity
Copy link
Contributor

Hi @dragonwu0919

We have recently upgraded the Qt version to 6.8.1, could you change the version to 6.8.1?

@dragonwu0919
Copy link
Contributor Author

Hi @dragonwu0919

We have recently upgraded the Qt version to 6.8.1, could you change the version to 6.8.1?

Surely, I can do this.

@dragonwu0919
Copy link
Contributor Author

@xingularity Could you please help me review the PR? thank you.

Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonwu0919 could you please do a rebase to remove the unnecessary merge in the PR for this simple patch?

@dragonwu0919 dragonwu0919 force-pushed the issue169 branch 2 times, most recently from 0a86a58 to 3345c2b Compare January 13, 2025 08:36
in scripts/build/qt, I change line 44 from `pkgbranch=${VERSION:-6.5.3}` to ` pkgbranch=${VERSION:-6.8.1}`.
@dragonwu0919
Copy link
Contributor Author

@dragonwu0919 could you please do a rebase to remove the unnecessary merge in the PR for this simple patch?

Thank for the reminding. I forgot to squash the redundant commits.

@yungyuc could you help me review the result? Thank you.

Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonwu0919 could you please do a rebase to remove the unnecessary merge in the PR for this simple patch?

Thank for the reminding. I forgot to squash the redundant commits.

@yungyuc could you help me review the result? Thank you.

LGTM

@yungyuc yungyuc merged commit 78344d2 into solvcon:main Jan 13, 2025
2 checks passed
@yungyuc yungyuc linked an issue Jan 13, 2025 that may be closed by this pull request
@yungyuc yungyuc mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build script enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect qt version
3 participants