Skip to content

Commit

Permalink
Add comment for the bypass reason
Browse files Browse the repository at this point in the history
  • Loading branch information
jimmyzhai committed Jan 16, 2025
1 parent f98f08c commit 24832bb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dash-pipeline/SAI/templates/impls/sai_api_func_quad.cpp.j2
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ static sai_status_t dash_sai_create_{{ api.name }}(
if (table_{{api.name}}_add_keys({{ api.name }}, matchActionEntry) == SAI_STATUS_NOT_SUPPORTED)
{
DASH_LOG_WARN("match field in {{ api.name }} not supported, API does nothing!");
return SAI_STATUS_SUCCESS; // bypass
return SAI_STATUS_SUCCESS; // bypass, temporary workaround for issue #656
}
return dashSai->create({{meta_table}}, obj_type, matchActionEntry, attr_count, attr_list);
{% endif %}
Expand All @@ -49,7 +49,7 @@ static sai_status_t dash_sai_remove_{{ api.name }}(
if (table_{{api.name}}_add_keys({{ api.name }}, matchActionEntry) == SAI_STATUS_NOT_SUPPORTED)
{
DASH_LOG_WARN("match field in {{ api.name }} not supported, API does nothing!");
return SAI_STATUS_SUCCESS; // bypass
return SAI_STATUS_SUCCESS; // bypass, temporary workaround for issue #656
}
return dashSai->remove({{meta_table}}, matchActionEntry);
{% endif %}
Expand All @@ -68,7 +68,7 @@ static sai_status_t dash_sai_set_{{ api.name }}_attribute(
if (table_{{api.name}}_add_keys({{ api.name }}, matchActionEntry) == SAI_STATUS_NOT_SUPPORTED)
{
DASH_LOG_WARN("match field in {{ api.name }} not supported, API does nothing!");
return SAI_STATUS_SUCCESS; // bypass
return SAI_STATUS_SUCCESS; // bypass, temporary workaround for issue #656
}
return dashSai->set({{meta_table}}, matchActionEntry, attr);
{% endif %}
Expand All @@ -88,7 +88,7 @@ static sai_status_t dash_sai_get_{{ api.name }}_attribute(
if (table_{{api.name}}_add_keys({{ api.name }}, matchActionEntry) == SAI_STATUS_NOT_SUPPORTED)
{
DASH_LOG_WARN("match field in {{ api.name }} not supported, API does nothing!");
return SAI_STATUS_SUCCESS; // bypass
return SAI_STATUS_SUCCESS; // bypass, temporary workaround for issue #656
}
return dashSai->get({{meta_table}}, matchActionEntry, attr_count, attr_list);
{% endif %}
Expand Down

0 comments on commit 24832bb

Please sign in to comment.