Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash-p4] Create macro for creating direct counters #523

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Feb 24, 2024

This is to simplify the code for creating and attaching the direct counters.

No SAI updates will be introduced with this change.

@r12f r12f marked this pull request as draft February 24, 2024 18:52
@r12f r12f force-pushed the user/r12f/counter branch 5 times, most recently from 386f923 to 3ca40d9 Compare February 25, 2024 17:07
@r12f r12f force-pushed the user/r12f/counter branch from 3ca40d9 to ef47129 Compare February 27, 2024 17:59
@r12f r12f marked this pull request as ready for review February 27, 2024 18:02
@r12f
Copy link
Collaborator Author

r12f commented Feb 27, 2024

ouch, seems like we get some infra issue with certs... let me retry the test and see.

image

@r12f
Copy link
Collaborator Author

r12f commented Feb 27, 2024

retry works! great!

@r12f r12f merged commit 7070b51 into sonic-net:main Feb 28, 2024
4 checks passed
@r12f r12f deleted the user/r12f/counter branch February 28, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants