Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash-p4] Remove original overlay IP from encap data and reuse the existing fields. #529

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Feb 29, 2024

The original overlay dip/sip looks to be redundant and can directly reuse the overlay data we already have in the metadata, hence doing this change.

@r12f r12f changed the title [dash-p4] Remove encap data original overlay IP and reuse the existing fields. [dash-p4] Remove original overlay IP from encap data and reuse the existing fields. Feb 29, 2024
Copy link
Collaborator

@marian-pritsak marian-pritsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for saving the original SIP is that it may be changed by 4to6 transformation, but we may still need to refer to the original value along the pipeline.

@KrisNey-MSFT
Copy link
Collaborator

hey @jafingerhut - did this look ok to you (for merge)?

@jafingerhut
Copy link
Contributor

@KrisNey-MSFT Executive summary: I am OK with merging this, but that does not provide much higher assurance that these are the changes you want.

Gory details:
For the functional correctness of the changes according to the desired data plane behavior for the DASH project, I am not the best person to review this, unfortunately.

For whether it compiles and runs on P4 DPDK, I believe Chris Sommers has created Github actions/workflow stuff that automatically checks whether it compiles without error, but the various DASH blocking issue for P4 DPDK prevent us from automating checks that pass packets through. Those checks for BMv2 should both compile and pass packets through on every commit, I believe.

@r12f r12f force-pushed the user/r12f/original-ip branch from 62d23c9 to 4f44202 Compare March 11, 2024 21:48
@KrisNey-MSFT KrisNey-MSFT merged commit 924dde9 into sonic-net:main Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants