Pr fix sai_thrift import error #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing below error
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_client/sai_thrift_client/sai_thrift_client.py:8: in <module>
from saichallenger.common.sai_client.sai_thrift_client.sai_thrift_utils import *
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
import re
from itertools import zip_longest
import ipaddress
import json
> from sai_thrift import sai_headers
E ModuleNotFoundError: No module named 'sai_thrift'
python3 setup.py install changed to pip3 install .
Update Dockerfile.saichallenger-client to Fix "ModuleNotFoundError: No module named 'sai_thrift'"
|
This PR will fix #613 |
|
@r12f Could you please review the changes in PR at your convenience? If everything looks good, kindly approve and merge the changes. |
|
adding @r12f as a reviewer |
r12f
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing below error
"python3 setup.py install" CHANGED to "pip3 install ." in Dockerfile.saichallenger-client.
python3 setup.py install , installs files in /usr/lib/python3.9/site-packages/ which is not in sys.path
pip3 install . , installs filesin /usr/local/lib/python3.9/dist-packages/ which is in sys.apth