-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom ACL Based Metering #1889
base: master
Are you sure you want to change the base?
Custom ACL Based Metering #1889
Conversation
Describes the Custom ACL Based Metering (CABM) feature design in SONiC.
/azp run |
|
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
Community review recording https://zoom.us/rec/share/29B51B0VyrGy4h27zWOcrKVfzRgto8ONES9h5QPRFjek-d2iFMRthW5mabfAG6TW.PN8n9aVAa1gO4D5u |
|
||
#### **Configuration Flow** | ||
|
||
![alt text](Config_Flow.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are validating the ACL action policer capability based on information from STATE_DB, please use it in the diagram.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ACL-Orch saves the information in both STATE_DB and local DB. So in my case, I can just check the local DB.
##### ACL Table Type Table | ||
When a new ACL table is created, SAI needs to receive a list of supported actions which the rules belonging to this table are allowed to use. | ||
To support the new policer action, the custom table types table schema will be extended with a policer action attribute - **"POLICER_ACTION"** for the actions attribute field. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please highlight the changes done on top of the existing tables for this feature.
... | ||
+ /* prevent deletion of policer that referenced by ACL rule. | ||
+ Note that new policer won't be referenced by any ACL rules initially */ | ||
+ must "not(../acl:sonic-acl/acl:ACL_RULE/acl:ACL_RULE_LIST[acl:policer_action=current()/name])" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be required, please double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks. I'll update the HLD accordingly.
/azp run |
No pipelines are associated with this pull request. |
@venkatmahalingam @bingwang-ms Can you please review? |
Describes the Custom ACL Based Metering (CABM) feature design in SONiC.
[AclOrch] Custom ACL Based Metering
[sonic-buildimage] Custom ACL Based Metering
[sonic-utilities] Custom ACL Based Metering