EVPN_VXLAN_HLD: update to allow recording for p2mp remote vteps #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complimentary ticket to sonic-net/sonic-swss#3480 in order to allow p2mp vteps to be tracked. This will mostly aid in debugging. The HLD specifically states this when talking about P2P vs P2MP: "For an external user, there will be no changes from usability perspective since the schema is unchanged." However this is not entirely true since the state table wasn't recording p2mp remote vteps and therefore `show vxlan remotevtep` would return no results making a user believe the vxlan tunnel was not properly established. This as well as the aforementioned PR corrects this oversight. Signed-off-by: Brad House (@bradh352)
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@dgsudharsan mind reviewing this change? You seem to have been the one to contribute the P2MP vs P2P information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complimentary ticket to sonic-net/sonic-swss#3480 in order to allow p2mp vteps to be tracked. This will mostly aid in debugging. The HLD specifically states this when talking about P2P vs P2MP:
"For an external user, there will be no changes from usability perspective since the schema is unchanged."
However this is not entirely true since the state table wasn't recording p2mp remote vteps and therefore
show vxlan remotevtepwould return no results making a user believe the vxlan tunnel was not properly established. This as well as the aforementioned PR corrects this oversight.Signed-off-by: Brad House (@bradh352)