Packet Trimming HLD #1898
Packet Trimming HLD #1898
Conversation
Signed-off-by: Nazarii Hnydyn <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
| | Switch trimming update: error | ERROR | | ||
| | Buffer profile trimming update: success | NOTICE | | ||
| | Buffer profile trimming update: error | ERROR | | ||
|
|
There was a problem hiding this comment.
Can you define the scope of the support and/or notable constraints? Eg,
-
Is trimming support expected for both IPv4 and IPv6?
-
Does it support IP multicast frames? Would trimmed pkts be replicated and reach all receivers for retransmission request?
-
What if the pkt to trim is destined for local tunnel decapsulation? Would it trim from the original frame or decapsulated frame?
There was a problem hiding this comment.
@adyeung the quick answer: all these things are vendor specific behavior. The current plan is not to extend the scope section. It has nothing to do with a trimming configuration. For the first question the answer is yes. Both IPv4/IPv6 supports trimming.
| key = SWITCH_TRIMMING|GLOBAL ; switch trimming global. Must be unique | ||
|
|
||
| ; field = value | ||
| size = 1*10DIGIT ; size (in bytes) to trim eligible packet |
There was a problem hiding this comment.
Should size be restricted to 4DIGIT similar to mtu?
There was a problem hiding this comment.
@pavannaregundi the YANG model implementation is according to SAI API.
We do not want explicitly to add any limitations here.
https://github.com/opencomputeproject/SAI/blob/master/inc/saiswitch.h#L3158
SAI API:
/**
* @brief Trim packets to this size to reduce bandwidth
*
* @type sai_uint32_t
* @flags CREATE_AND_SET
* @default 128
*/
SAI_SWITCH_ATTR_PACKET_TRIM_SIZE,
|
|
||
| leaf size { | ||
| description "Size (in bytes) to trim eligible packet"; | ||
| type uint32; |
There was a problem hiding this comment.
Should size be same as MTU?
type uint16 {
range 68..9216;
}
There was a problem hiding this comment.
@pavannaregundi the YANG model implementation is according to SAI API.
We do not want explicitly to add any limitations here.
https://github.com/opencomputeproject/SAI/blob/master/inc/saiswitch.h#L3158
SAI API:
/**
* @brief Trim packets to this size to reduce bandwidth
*
* @type sai_uint32_t
* @flags CREATE_AND_SET
* @default 128
*/
SAI_SWITCH_ATTR_PACKET_TRIM_SIZE,
Signed-off-by: Nazarii Hnydyn <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Nazarii Hnydyn [email protected]
This document provides general information about Packet Trimming implementation in SONiC
In scope: