Azp: install sonic yangs during pipline build #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase. It cannot be merged as it is now. |
|
@sachinholla The PR cannot be merged as it is reported out-of-date. |
sachinholla
force-pushed
the
azp_fix
branch
from
e571e84 to
5a5d974
Compare
sachinholla
force-pushed
the
azp_fix
branch
from
5a5d974 to
650e5df
Compare
sachinholla
force-pushed
the
azp_fix
branch
2 times, most recently
from
280082a to
1b2483c
Compare
kwangsuk
reviewed
Nov 16, 2023
| @@ -101,6 +101,10 @@ stages: | |||
| sudo dpkg -i ../target/debs/bullseye/libyang*1.0.73*.deb | |||
| displayName: "Install dependency" | |||
|
|
|||
| - script: | | |||
There was a problem hiding this comment.
To install coherent packages related to YANG, it would be cleaner if you replace "-script" with the comment "# YANG MODELS" to run after libyang package install. If you want to keep the separate script, please add the same comment.
There was a problem hiding this comment.
I prefer keeping it as a separate step.. Will add a comment.. Step's displayName attribute anyway indicates "Install sonic yangs"
kwangsuk
approved these changes
Nov 17, 2023
anand-kumar-subramanian
force-pushed
the
azp_fix
branch
from
7eff69f to
280b7f4
Compare
* Download & install sonic_yang_models.whl before telemetry build. Translib code generators and app modues use these sonic yangs * Download source code and artifacts for the build branch only * Use pipeline 142 for downloading sonic-buildimage.vs artifacts, which runs on all branches
anand-kumar-subramanian
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Translib infra (sonic-mgmt-common) has an option to import cvl sonic yangs from sonic-yang-models.whl. This option is not enabled right now, but will be in near future. Hence sonic-yang-models.whl needs to be installed on the vm.
Also backport the pipeline build fixes done in 202305 branch.
How I did it
How to verify it
PR build
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)