Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOI Implementation of OS.Verify #342

Merged
merged 18 commits into from
Jan 28, 2025
Merged

Conversation

hdwhdw
Copy link
Contributor

@hdwhdw hdwhdw commented Jan 21, 2025

Why I did it

Supports OS.Verify for Upgrading OS

How I did it

Implement GNOI server and client for GNOI.OS.Verify

Backend PR: sonic-net/sonic-host-services#206

How to verify it

On Mellanox:
gnoi_client -target 127.0.0.1:50052 -logtostderr -insecure -module OS -rpc Verify
OS Verify
{"version":"SONiC-OS-20240510.23"}

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

GNOI OS.Verify implementation.

Backend PR: sonic-net/sonic-host-services#206

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link

/azp run

@hdwhdw hdwhdw changed the title Os verify GNOI Implementation of OS.Verify Jan 21, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hdwhdw hdwhdw marked this pull request as ready for review January 23, 2025 19:47
@qiluo-msft
Copy link
Collaborator

How to verify it? could you add more details into PR description above?

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hdwhdw hdwhdw requested a review from Copilot January 27, 2025 20:01
@hdwhdw
Copy link
Contributor Author

hdwhdw commented Jan 27, 2025

sonic-gnmi test failure due to sonic-host-services dependencies merged but yet to be picked up by the pipeline. Manual integration test successful:

gnoi_client -target 127.0.0.1:50052 -logtostderr -insecure -module OS -rpc Verify
OS Verify
{"version":"SONiC-OS-20240510.23"}

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Collaborator

I notice one empty line added. Could you prevent unnecessary code change?


Refers to: test/utils.py:319 in 82bf840. [](commit_id = 82bf840, deletion_comment = False)

@qiluo-msft qiluo-msft merged commit a023991 into sonic-net:master Jan 28, 2025
7 checks passed
@hdwhdw hdwhdw deleted the os_verify branch January 29, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants