[action] [PR:527] Create is_transceiver_vdm_supported API for CMIS transceivers #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Provide a general summary of your changes in the Title above -->
#### Description
<!--
Describe your changes in detail
-->
is_transceiver_vdm_supported API needs to be created so that xcvrd can directly skip freezing/unfreezing of VDM stats (done to read VDM and PM data from the transceiver) for transceivers which do not support VDM feature.
#### Motivation and Context
<!--
Why is this change required? What problem does it solve?
If this pull request closes/resolves an open Issue, make sure you
include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
XCVRD will call `is_transceiver_vdm_supported` API before performing freeze of VDM stats.
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
Following types of modules were tested with this changeset
1. CMIS module supporting VDM - ensured is_transceiver_vdm_supported returns True
2. SFF-8472 module - ensured is_transceiver_vdm_supported returns False
#### Additional Information (Optional)
MSFT ADO - 30657693
|
Original PR: #527 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is_transceiver_vdm_supported API needs to be created so that xcvrd can directly skip freezing/unfreezing of VDM stats (done to read VDM and PM data from the transceiver) for transceivers which do not support VDM feature.
Motivation and Context
XCVRD will call
is_transceiver_vdm_supportedAPI before performing freeze of VDM stats.How Has This Been Tested?
Following types of modules were tested with this changeset
Additional Information (Optional)
MSFT ADO - 30657693