Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed xcvrd to pull all fields #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed xcvrd to pull all fields #99

wants to merge 1 commit into from

Conversation

ade-d
Copy link

@ade-d ade-d commented Oct 9, 2020

@ghost
Copy link

ghost commented Oct 9, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

geans-pin
geans-pin reviewed Oct 12, 2020
View reviewed changes
Copy link

@geans-pin geans-pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the UT log

@jleveque jleveque requested a review from keboliu November 6, 2020 02:24
@keboliu
Copy link
Collaborator

keboliu commented Nov 10, 2020

I left some comments in relate PR sonic-net/sonic-platform-common#129, and then get back to this one.

vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
@jleveque
[SfpBase] Fix key name typo in docstring (sonic-net#99)
42781ff 
Fix key name typo: "mominal_bit_rate" -> "nominal_bit_rate"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geans-pin geans-pin geans-pin left review comments

@keboliu keboliu Awaiting requested review from keboliu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement xcvrd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ade-d @keboliu @geans-pin @jleveque