Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jan 20, 2025
| @patch('os.access', return_value=True) | ||
| @patch('os.statvfs', return_value=os.statvfs_result((4096, 4096, 1909350, 1491513, 4096, | ||
| 971520, 883302, 883302, 4096, 255))) | ||
| def test_unmount_disk_full(self, mock_os_statvfs, mock_os_access, mock_rmtree, mock_proc, mock_log): |
There was a problem hiding this comment.
Yes, this test will cover recovery case.
I also will add a sonic-mgmt test to cover the disk-full scenario.
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Add disk full event to sonic-events-host yang model. Why I did it This PR need publish disk full event: sonic-net/sonic-utilities#3700 Work item tracking Microsoft ADO: 30608100 How I did it Add disk full event to yang model. How to verify it Pass all UT. Description for the changelog Add disk full event to sonic-events-host yang model.
saiarcot895
reviewed
Jan 22, 2025
| for d in dirs: | ||
| d_name = get_dname(d) | ||
|
|
||
| ret = run_cmd(["umount", "-l", "{}_{}".format(overlay_prefix, d_name)]) |
There was a problem hiding this comment.
It's worth noting that if there's some process in /etc or /home (including any user's shell being in their home directory), then this will most likely fail. I guess since disk_check.py gets executed frequently, it'll eventually work, at least.
There was a problem hiding this comment.
This will not fail because unmount with -l, lazy mode will wait and unmount in background.
saiarcot895
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login.
This PR depends on DB schema change: sonic-net/sonic-buildimage#21351
What I did
How I did it
How to verify it
Work item tracking
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)