Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call for spanning-tree commands in dump script #3723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidZagury
Copy link
Contributor

What I did

Fix the calls for spanning-tree commands in dump script.
During call to generate techsupport, we can see that the spanning tree commands fail:

.
Error: No such command "spanning_tree".
timeout --foreground 5m bash -c "dummy_cleanup_method ()
.

How I did it

Change from show spanning_tree to the actual command show spanning-tree

How to verify it

Call show techsupport

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury marked this pull request as ready for review January 22, 2025 12:58
Copy link
Contributor

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we'll need some test for generate_dump flow.

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Jan 27, 2025
@qiluo-msft
Copy link
Contributor

@DavidZagury could you add a sonic-mgmt or unit test to prevent regression like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants