Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Add <FieldBox.TopAddon /> in TextField's topAddon prop. #236

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Brokyeom
Copy link
Member

변경사항

  • TextField의 topAddon에 새로 변경된 FieldBox의 레이아웃이 적용되지 않았던 문제를 수정했어요.
  • FieldBox의 TopAddon을 감싸줌으로써 온전한 FieldBox의 레이아웃을 가질 수 있도록 수정했습니다.

링크

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

Copy link

height bot commented Jan 12, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Jan 12, 2025

🦋 Changeset detected

Latest commit: 671d07a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sopt-makers/ui Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jungwoo3490 jungwoo3490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@Brokyeom Brokyeom merged commit f5434c6 into main Jan 13, 2025
2 checks passed
@Brokyeom Brokyeom deleted the fix/ui-textfield-top-addon branch January 13, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants