Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added reset button to plots #1030

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Added reset button to plots #1030

merged 5 commits into from
Apr 29, 2024

Conversation

JawHawk
Copy link
Member

@JawHawk JawHawk commented Apr 4, 2024 •
edited by PhilippWendler
Loading

Fixes #1018.

  • Created renderResetButton in plot.js
  • this.state contains all the specific plot parameters. An object with all params keys from this.state with value null is passed to setURLParameter function which removes them from the URL .
  • Build is also updated

Attached is the video of the working -

resetbutton-2024-04-04_19.33.44.mp4

@JawHawk
Copy link
Member Author

JawHawk commented Apr 7, 2024

@PhilippWendler Are there any changes needed ?

PhilippWendler
PhilippWendler reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I have added some thoughts about a few places where I think we could improve it a little bit. But overall I think this is the correct approach, the button is in the best place and it work.s

benchexec/tablegenerator/react-table/src/components/QuantilePlot.js Outdated Show resolved Hide resolved
benchexec/tablegenerator/react-table/src/components/ScatterPlot.js Outdated Show resolved Hide resolved
benchexec/tablegenerator/react-table/src/utils/plot.js Outdated Show resolved Hide resolved
benchexec/tablegenerator/react-table/src/utils/plot.js Outdated Show resolved Hide resolved
@JawHawk JawHawk requested a review from PhilippWendler April 22, 2024 12:40
PhilippWendler
PhilippWendler approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, works perfectly!

@PhilippWendler
Update pre-built file
cbf3254 
It seems it was changed somehow although when I build it
I get the same file as on the main branch.
@PhilippWendler PhilippWendler merged commit 71dc484 into sosy-lab:main Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippWendler PhilippWendler PhilippWendler approved these changes

Assignees
No one assigned
Labels
HTML table
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Reset Button to the scatter and quantile plot webpage
2 participants
@JawHawk @PhilippWendler