Upgrade React Router to V6 #1054
Conversation
|
The immediate issue I am facing is that the tests for |
PhilippWendler
changed the title
wip: Upgrade React Router to V6
|
Seems to work seamlessly in my first tests. Very nice! And a much smaller PR than I had feared. :-)
There are several errors with the message "Error: Not implemented: navigation (except hash changes)" shown in the log. My guess would be that something attempts to change the URL. There are also stacktraces available for these errors that should help. |
|
Yes sir. I have been trying to figure out this error and tried again all the solutions that I had researched when I faced this problem earlier while working on different PR, but to no avail. I have some other ideas and hope to complete my experimentation with them by this weekend. I will keep adding updates on my progress here. |
|
Update: I got the URL navigation working! We are on a particular version of Jest, which doesn't allow overwriting the There is another minor hiccup, though. Some snapshots for the
|
🎉
Hm. Could be, but if I look at the start of the changes I see that the test now renders a different column in the plot. This might look more like if some state change is not picked up? Note that the test is named "Quantile Plot should match HTML snapshot with selection of the type status" and we previously had the status column, but now there is a different column.
Not that I am aware of. Maybe google for this?
I think it is more likely that the test is not behaving correctly right now due to the mismatch between test name and test result. |
|
Got it sir. Will try to fix this as soon as possible. |
|
I have fixed the errors in the test and the application. This PR is now ready for review! |
benchexec/tablegenerator/react-table/src/tests/QuantilePlot.test.js
Outdated
Show resolved
Hide resolved
benchexec/tablegenerator/react-table/src/components/Overview.js
Outdated
Show resolved
Hide resolved
|
Thanks a lot! I found two related problems with state updates. If I configure a filter in the filter sidebar and keep the sidebar open while changing tabs, the filter is lost. Similarly, if I change a filter via the drop down and then change tabs, the filter is lost. Here is a video of the former case: Could you please have a look? Aside from this, everything seems to work fine. 👍 |
|
Okay, sir! I can confirm that these bugs are replicable on my end as well. Will try to patch the same and will update here. |
|
@PhilippWendler This is ready for review. |
|
I still get some weird behavior when clicking around with filters. For example, the drop down filter first doesn't update and then the UI seems to lag one filter behind what is actually being applied as a filter. Similar with the sidebar. Can you reproduce or should I make a video? |
On Ubuntu since 24.04, user namespaces are forbidden for regular users (cf. sosy-lab#1041 and sosy-lab#1042). There is a global sysctl switch to enable them again, but applications whose AppArmor profile allows this can also use it. (Typically, AppArmor only restricts application, but in this case an AppArmor profile can actually provide a privilege than an unconfined application does not have.) More explanations are at https://ubuntu.com/blog/ubuntu-23-10-restricted-unprivileged-user-namespaces In order to make BenchExec usable out-of-the-box after installing the .deb package we want to ship such an AppArmor profile. This is made complicated by the fact that the AppArmor profile that is necessary on Ubuntu 24.04+ breaks AppArmor on previous Ubuntu versions. So we have to install this profile conditionally. I found a way to do so using ucf (a tool for handling config files) and this seems to work in my tests on Ubuntu 22.04 (old AppArmor), Ubuntu 24.04 (new AppArmor), and Debian 12 (old AppArmor), as well as installation without AppArmor present. There are two known remaining problems: - If one upgrades from Ubuntu 22.04 to Ubuntu 24.04 while having BenchExec installed, the AppArmor profile will not be installed, so BenchExec will not work. Upgrading or reinstalling the BenchExec package makes it work. - The command "python3 -m benchexec.test_tool_info" will not work, because the AppArmor profile won't match it. One has to either disable container mode or temporarily allow the use of user namespaces for the whole system. If we implement sosy-lab#1053 this would just work. Part of sosy-lab#1041.
This was a race condition if a process in the same cgroup as BenchExec stopped while we check its status.
…default and SV-COMP wrapper In `executable()`, we look for `bin/sea_svcomp` (the SV-COMP wrapper) first. If it does not exist, then we look for `bin/sea` (the default wrapper).
CPAchecker will use bin/cpachecker instead of scripts/cpa.sh soon (cf. https://gitlab.com/sosy-lab/software/cpachecker/-/issues/632). We will support both in the tool-info module. Same change is also done for CPA-Witness2Test, which also has its executable renamed.
This is a preparation for the next commit.
CPAchecker will soon use command-line arguments with "--" as prefix. The old arguments will continue to be supported, but we want to use the new ones in the tool-info module when possible in order to not confuse users. So let's let the tool-info module adapt to the options that the user specified in the benchmark definition. Cf. https://gitlab.com/sosy-lab/software/cpachecker/-/issues/1218
Previously, the tool-info module of CPAchecker ensured that the executable of CPA-witness2test is covered by program_files(), because the scripts/ directory is part of the program files. But for new versions of CPAchecker we do not add all of bin/ to the program files, so we need to explicitly add cpa-witness2test.
Since version 69.3.0 the names of the produced build artifacts changes, but we prefer to keep the old names for compatibility.
SMT-COMP started to use BenchExec this year, and for Termination Competition is an important part of their measurement setup: https://lists.rwth-aachen.de/hyperkitty/list/[email protected]/thread/6RTY4BDARIS74HSSUDJQYYQNURHIZ7IR/
As announced in the changelog of BenchExec 3.22 and on the issue tracker. Part of sosy-lab#986.
According to the man page debhelper-compat-upgrade-checklist level 11 is deprecated and not recommended. A test build on level 12 produces an identical .deb package (same hash), so it seems we can safely upgrade. Also switch how we specify the compatibility level: In debian/control instead of debian/compat, because right now we need to specify it in two places.
This makes it work without requiring sudo.
We have a heuristic that checks if CPAchecker is used from source but misses a rebuild. This would crash if broken symlinks or other file-access problems occur. As it is just an optional feature, we can ignore such problems and print a warning. An example where this happened was for example system-wide installation of CPAchecker with the executable being /usr/bin/cpachecker and /usr/src existing.
We do not need to scan through the src directory of CPAchecker if we are not going to use the information anyway. So check this first.
|
I seem to have messed up the git history of this branch (I rebased |
Upgrades from React Router V5 to React Router V6.
The primary changes included in this PR:
Appcomponent from a class component to a functional component:I did it while experimenting with different ways to use hooks like
useNavigateanduseLocationin theOverviewcomponent. In the end, I did not need it, but it is a good change to keep in my opinion.Switchcomponents toRoutecomponentshistoryobject to other meansInitially, I tried converting the
Overviewcomponent to a functional one. Still, the same resulted in many breaking changes as I am unfamiliar with what and how each function works. I think so I have found a way that allows us to continue using class components, which integrating it with hooks, that doesn't involve too much of a rewrite and refactoring.Fixes #805.