Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WitnessMap always returns the version directl #1119

Merged
merged 1 commit into from
Nov 21, 2024
Merged

WitnessMap always returns the version directl #1119

merged 1 commit into from
Nov 21, 2024

Conversation

marian-lingsch
Copy link
Contributor

@marian-lingsch marian-lingsch commented Nov 21, 2024 •
edited
Loading

The previous implementation was a bug, since WitnessMap does produces 0.0.1-dev for the following:

./witness_map.py --version

WitnessMap always returns the version directly when queried with --ve…
ed45f79 
…rsion

The previous implementation was a bug
@marian-lingsch marian-lingsch self-assigned this Nov 21, 2024
@dbeyer dbeyer merged commit 0a3697c into main Nov 21, 2024
13 of 15 checks passed
@dbeyer dbeyer deleted the witnessmap-version-fix branch November 21, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeyer dbeyer dbeyer approved these changes

@PhilippWendler PhilippWendler Awaiting requested review from PhilippWendler

Assignees

@marian-lingsch marian-lingsch

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marian-lingsch @dbeyer