Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync private repo with this public repo #12

Merged
merged 8 commits into from
Jan 7, 2024
Merged

Sync private repo with this public repo #12

merged 8 commits into from
Jan 7, 2024

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Jan 2, 2024

I am syncing the private XuhuiZhou/sotopia repo to this repo.

Here are the items that we want to move to this repo.

  • poetry, pyproject
  • stubs
  • docs
  • tests
  • FastAPI related bug fix
  • script agent by @bugsz and @XuhuiZhou

@bugsz and @XuhuiZhou please move related code under sotopia/sotopia to this repo (I have already moved docs and tests).

@lwaekfjlk @ruiyiw @Jasonqi146 @sharonwx54 please check the updates to make sure this PR won't break anything you have done.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

@XuhuiZhou
Copy link
Member

@bugsz @ProKil I think i have added the script writing mode and related examples! @bugsz Can you double check?

Copy link
Contributor

@bugsz bugsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a brief check on full-form script generation and it seems to work well.
We could add them back if we find anything missing in the future.

@ruiyiw
Copy link
Contributor

ruiyiw commented Jan 7, 2024

It works well on our project. Thanks

@ProKil ProKil merged commit 0c612b2 into main Jan 7, 2024
3 checks passed
@ProKil ProKil deleted the feature/sync branch March 11, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants