Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding LLM Agents (Interview setting using openhands) to Sotopia Aact (Experimental) #248

Merged
merged 15 commits into from
Nov 16, 2024

Conversation

akhatua2
Copy link
Contributor

@akhatua2 akhatua2 commented Nov 13, 2024

📑 Description

This pull request introduces llm agent to the sotopia aact project:

  • Import Path Updates: Corrected import paths in various files to ensure that the BaseAgent class is imported from the correct location (sotopia.experimental.agents.base_agent).
  • LLMAgent Class Addition: Added a new LLMAgent class in llm_agent.py, extending the BaseAgent class. This class includes methods for sending messages, formatting message history, and handling different types of agent actions.
  • Configuration Settings: Added configuration settings for LLM agents, including their goals, model names, and communication channels.
  • Error Handling and Code Cleanup: Refactored the BaseAgent class to include error handling and improved code organization.

✅ Checks

  • My pull request adheres to the code style of this project
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

Update the goals in the interview_openhands.toml file. Then to run this:

 uv run aact run-dataflow examples/experimental/interview_openhands/interview_openhands.toml

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (7d2ab2f) to head (c2e3656).
Report is 16 commits behind head on main.

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          58       58           
  Lines        2972     2972           
=======================================
  Hits         2166     2166           
  Misses        806      806           
Files with missing lines Coverage Δ
sotopia/experimental/__init__.py 100.00% <100.00%> (ø)
sotopia/experimental/agents/base_agent.py 97.50% <100.00%> (ø)

@akhatua2 akhatua2 marked this pull request as ready for review November 13, 2024 01:22
@akhatua2 akhatua2 requested a review from ProKil November 13, 2024 01:22
@akhatua2 akhatua2 changed the title feat: Adding LLM Agents to Sotopia feat: Adding LLM Agents to Sotopia Aact (Experimental) Nov 13, 2024
@ProKil
Copy link
Member

ProKil commented Nov 15, 2024

Just a nitpick can you change the name of the example to interview_openhands? This will make it more specific

@akhatua2 akhatua2 changed the title feat: Adding LLM Agents to Sotopia Aact (Experimental) feat: Adding LLM Agents (Interview setting using opehands) to Sotopia Aact (Experimental) Nov 15, 2024
@akhatua2 akhatua2 changed the title feat: Adding LLM Agents (Interview setting using opehands) to Sotopia Aact (Experimental) feat: Adding LLM Agents (Interview setting using openhands) to Sotopia Aact (Experimental) Nov 15, 2024
@ProKil
Copy link
Member

ProKil commented Nov 15, 2024

I found the documentation is missing for this example. Can you also add how to set up the openhands node and the completely instruction for running this example under examples/experimental/interview_openhands/readme.md?

@ProKil
Copy link
Member

ProKil commented Nov 16, 2024

After you add the documentation for that, feel free to merge this PR.

@akhatua2 akhatua2 merged commit 53e0798 into main Nov 16, 2024
9 checks passed
@ProKil ProKil deleted the openhands_integration branch November 16, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants