-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix empty background issue #27
Conversation
I think there are some conflicts with previous expectations? sotopia/tests/renderers/test_xml_renderer.py Lines 90 to 97 in eac12c8
|
@bugsz Thanks for your contribution. Can you describe the test case and what your expected outputs are? |
I think what Xuhui wants is to make the speaker background visible while the listener invisible?
|
@bugsz that makes sense. Would you mind updating that test case and reply me with a link to it? |
… stranger relations
@ProKil Here is the updated test case. sotopia/tests/renderers/test_xml_renderer.py Lines 64 to 99 in fd6700a
|
Closes #24
📑 Description
Since in
stranger
relations the other's background is not visible, usingand
will wipe out all backgrounds. So we useor
instead.@XuhuiZhou Here is the fix. I will run experiments later and we can merge after it behaves correctly
✅ Checks
type/descript
(e.g.feature/add-llm-agents
)ℹ Additional Information