Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(provider): readme update for Stripe Billing Package Integration #5

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

Tyagi-Sunny
Copy link
Collaborator

Description

readme update for stripe billing package integration

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

update readme for stripe integration

gh-0
@yeshamavani
Copy link
Collaborator

PR title - this is not a feature just docs are updated

@Tyagi-Sunny Tyagi-Sunny changed the title feat(provider): readme update for Stripe Billing Package Integration docs(provider): readme update for Stripe Billing Package Integration Nov 4, 2024
README.md Outdated
@@ -93,21 +91,69 @@ The loopback4-billing package relies on the configuration of the chosen billing

### Step 1: Set Up Billing Provider

#### ChargeBee -

#### For ChargeBee -
To use Chargebee as the billing provider, you need to configure the Chargebee API keys and site URL in your application. You can set these values in the environment variables of your LoopBack 4 project.

```
CHARGEBEE_API_KEY=your_chargebee_api_key

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of this variable.. I do not see this variable used below any where.

README.md Outdated
@@ -93,21 +91,69 @@ The loopback4-billing package relies on the configuration of the chosen billing

### Step 1: Set Up Billing Provider

#### ChargeBee -

#### For ChargeBee -
To use Chargebee as the billing provider, you need to configure the Chargebee API keys and site URL in your application. You can set these values in the environment variables of your LoopBack 4 project.

```
CHARGEBEE_API_KEY=your_chargebee_api_key
CHARGEBEE_SITE_URL=your_chargebee_site_url

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this, no use of this declared variable.

update the readme

gh-readme
update readme

gh-0
add line break

gh-0
@yeshamavani yeshamavani merged commit 79e37b3 into master Nov 19, 2024
4 checks passed
@yeshamavani
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants