Skip to content

Commit

Permalink
Merge branch 'master' into gh-2207
Browse files Browse the repository at this point in the history
  • Loading branch information
yeshamavani authored Nov 21, 2024
2 parents 5f062f9 + e34e826 commit 5da4d93
Show file tree
Hide file tree
Showing 20 changed files with 314 additions and 229 deletions.
7 changes: 0 additions & 7 deletions packages/cli/src/__tests__/suite/scaffold.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -136,7 +135,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -204,7 +202,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -263,7 +260,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -323,7 +319,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -390,7 +385,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down Expand Up @@ -424,7 +418,6 @@ export const scaffoldSuite = [
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
},
output: 'helm test path',
},
Expand Down
11 changes: 0 additions & 11 deletions packages/cli/src/command-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,6 @@ export default abstract class CommandBase<T extends object> extends Command {
}
}
}
if (options['jenkinsfile']) {

const helmPathPrompt: Question = {
type: 'input',
name: 'helmPath',
message: 'Enter the path for Helm chart:',
default: '',
};
const helmPathAnswer = await this.prompt([helmPathPrompt]);
options['helmPath'] = helmPathAnswer['helmPath'];
}
}

private createPromptObject<S>(flag: IFlag<S>) {
Expand Down
5 changes: 5 additions & 0 deletions packages/cli/src/commands/scaffold.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ export class Scaffold extends Base<ScaffoldOptions> {
'Do you want to create a Jenkinsfile for Helm-based deployment on Kubernetes?',
required: false,
}),
helmPath: flags.string({
name: 'helmPath',
description: 'Enter the path for Helm chart:',
dependsOn: ['jenkinsfile'],
}),
};
static readonly args = [
{name: 'name', description: 'name of the project', required: false},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ npm-debug.log
/dist
# Cache used by TypeScript's incremental build
*.tsbuildinfo
mochawesome-report
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules/
dist/
coverage/
.eslintrc.js
mochawesome-report
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"exit": true,
"recursive": true,
"require": "source-map-support/register",
"reporter": "mochawesome"
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dist
*.json
coverage
coverage
mochawesome-report
node_modules/
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch Program",
"skipFiles": [
"<node_internals>/**"
],
"program": "${workspaceFolder}/dist/index.js",
},
{
"type": "node",
"request": "launch",
"name": "Run Mocha tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"runtimeArgs": [
"-r",
"${workspaceRoot}/node_modules/source-map-support/register"
],
"cwd": "${workspaceRoot}",
"autoAttachChildProcesses": true,
"args": [
"--config",
"${workspaceRoot}/.mocharc.json",
"${workspaceRoot}/dist/__tests__/**/*.js",
"-t",
"0"
]
},
{
"type": "node",
"request": "attach",
"name": "Attach to Process",
"port": 5858
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"editor.rulers": [80],
"editor.tabCompletion": "on",
"editor.tabSize": 2,
"editor.trimAutoWhitespace": true,
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": "explicit",
"source.fixAll.eslint": "explicit"
},

"files.exclude": {
"**/.DS_Store": true,
"**/.git": true,
"**/.hg": true,
"**/.svn": true,
"**/CVS": true,
"dist": true
},
"files.insertFinalNewline": true,
"files.trimTrailingWhitespace": true,

"typescript.tsdk": "./node_modules/typescript/lib",
"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
"typescript.preferences.quoteStyle": "single",
"eslint.run": "onSave",
"eslint.nodePath": "./node_modules",
"eslint.validate": ["javascript", "typescript"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"label": "Watch and Compile Project",
"type": "shell",
"command": "npm",
"args": ["--silent", "run", "build:watch"],
"group": {
"kind": "build",
"isDefault": true
},
"problemMatcher": "$tsc-watch"
},
{
"label": "Build, Test and Lint",
"type": "shell",
"command": "npm",
"args": ["--silent", "run", "test:dev"],
"group": {
"kind": "test",
"isDefault": true
},
"problemMatcher": ["$tsc", "$eslint-compact", "$eslint-stylish"]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,13 @@ jobs:
run: npm run test --workspaces --if-present

- name: Run Lint Checks
run: npm run lint --workspaces --if-present
run: npm run lint --workspaces --if-present

- name: lerna-coverage
run: "npx lerna run coverage --concurrency 2"

- name: coverage report
id: coverage
uses: akshatdubeysf/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"bracketSpacing": false,
"singleQuote": true,
"printWidth": 80,
"trailingComma": "all",
"arrowParens": "avoid"
}
Loading

0 comments on commit 5da4d93

Please sign in to comment.