refactor(cli): add helmpath option in scaffold command (#2204)

add helmpath option in scaffold command GH-2199 Co-authored-by: yeshamavani <[email protected]>
sourcefuse · Nov 20, 2024 · 78a0875 · 78a0875
1 parent 4ee8419
commit 78a0875
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/packages/cli/src/__tests__/suite/scaffold.ts b/packages/cli/src/__tests__/suite/scaffold.ts
@@ -68,7 +68,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -136,7 +135,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -204,7 +202,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -263,7 +260,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -323,7 +319,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -390,7 +385,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },
@@ -424,7 +418,6 @@ export const scaffoldSuite = [
           type: 'input',
           name: 'helmPath',
           message: 'Enter the path for Helm chart:',
-          default: '',
         },
         output: 'helm test path',
       },

diff --git a/packages/cli/src/command-base.ts b/packages/cli/src/command-base.ts
@@ -92,17 +92,6 @@ export default abstract class CommandBase<T extends object> extends Command {
         }
       }
     }
-    if (options['jenkinsfile']) {
-
-      const helmPathPrompt: Question = {
-        type: 'input',
-        name: 'helmPath',
-        message: 'Enter the path for Helm chart:',
-        default: '',
-      };
-      const helmPathAnswer = await this.prompt([helmPathPrompt]);
-      options['helmPath'] = helmPathAnswer['helmPath'];
-    }
   }
 
   private createPromptObject<S>(flag: IFlag<S>) {

diff --git a/packages/cli/src/commands/scaffold.ts b/packages/cli/src/commands/scaffold.ts
@@ -43,6 +43,11 @@ export class Scaffold extends Base<ScaffoldOptions> {
         'Do you want to create a Jenkinsfile for Helm-based deployment on Kubernetes?',
       required: false,
     }),
+    helmPath: flags.string({
+      name: 'helmPath',
+      description: 'Enter the path for Helm chart:',
+      dependsOn: ['jenkinsfile'],
+    }),
   };
   static readonly args = [
     {name: 'name', description: 'name of the project', required: false},