Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search-service): add sequelize support in search service #1883

Merged
merged 5 commits into from
May 13, 2024

Conversation

Surbhi-sharma1
Copy link
Contributor

add sequelize support in search service

GH-1350

Description

add sequelize support in search service

Fixes #1350

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Surbhi-sharma1 Surbhi-sharma1 requested review from akshatdubeysf and a team as code owners January 2, 2024 15:06
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft January 2, 2024 15:06
@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-search-service branch 7 times, most recently from c344faf to d9cc3b2 Compare January 5, 2024 08:24
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review January 8, 2024 07:24
@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-search-service branch 4 times, most recently from f9f14b8 to 47df7dd Compare January 11, 2024 14:49
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
38.3% Duplication on New Code

See analysis details on SonarCloud

@Surbhi-sharma1
Copy link
Contributor Author

loopbackio/loopback-next#10312
Raised an issue related to this PR in loopback/next sequelize extension

@yeshamavani
Copy link
Contributor

Will be merged after the sequelize version is updated in all services.

@Surbhi-sharma1
Copy link
Contributor Author

#2047
will be merged after this PR

@Surbhi-sharma1
Copy link
Contributor Author

loopbackio/loopback-next#10312 Raised an issue related to this PR in loopback/next sequelize extension
the above mentioned PR is merged

@yeshamavani
Copy link
Contributor

@Surbhi-sharma1 version updates are done you can rebase this PR please test your changes in loopback-sequelize are working fine
once that is done we can merge this pR

@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-search-service branch 2 times, most recently from d968b09 to bb3080c Compare April 15, 2024 06:58
@Surbhi-sharma1 Surbhi-sharma1 force-pushed the GH-search-service branch 2 times, most recently from 83102f9 to 72739b4 Compare May 2, 2024 08:51
add where column

MIGRATION CHANGE:
migration-20240403122951- add where column

GH-1350
MIGRATION CHANGE:
migration-20240405080334- add sql migrations
migration-20231221041306- add sql migrations
migration-20240403122951- add sql migartions

GH-1350
MIGRATION CHANGE:
migration-20231221041306- resolve comments
migration-20240405080334- resolve comments
migration-20240403122951- resolve clomments

GH-1350
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.1% Duplication on New Code

See analysis details on SonarCloud

@yeshamavani yeshamavani merged commit 185092c into master May 13, 2024
5 checks passed
@yeshamavani yeshamavani deleted the GH-search-service branch May 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to switch to Sequelize ORM in Services
3 participants