Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user-tenant-service): add missing exports in user tenant service #1902

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

Tyagi-Sunny
Copy link
Contributor

@Tyagi-Sunny Tyagi-Sunny commented Jan 9, 2024

add missing exports in user tenant service

1901

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1901

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Tyagi-Sunny Tyagi-Sunny requested a review from a team as a code owner January 9, 2024 12:36
@Tyagi-Sunny
Copy link
Contributor Author

Tyagi-Sunny commented Jan 9, 2024

User Service did not give any error as , all these exports are included with in component.ts file of service and it was working fine. that's why we did not notice any error at that time

@yeshamavani
Copy link
Contributor

audit failing

@samarpan-b samarpan-b force-pushed the add-missing-export-in-user-service branch from 2b7d2f7 to 0b84367 Compare January 9, 2024 13:32
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yeshamavani yeshamavani merged commit d53bd6a into master Jan 10, 2024
5 checks passed
@yeshamavani yeshamavani deleted the add-missing-export-in-user-service branch January 10, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export missing in user tenant service
2 participants