Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update the developing.md.tpl in @sourceloop/cli while scaffolding #2213

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

Tyagi-Sunny
Copy link
Contributor

@Tyagi-Sunny Tyagi-Sunny commented Nov 18, 2024

Description

update the developing.md.tpl in @sourceloop/cli while scaffolding a monorepo.

Fixes #791

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Tyagi-Sunny Tyagi-Sunny requested a review from a team as a code owner November 18, 2024 11:31
@Tyagi-Sunny Tyagi-Sunny changed the title fix(cli): update the developing.md fix(cli): update the developing.md.tpl in @sourceloop/cli Nov 19, 2024
@Tyagi-Sunny Tyagi-Sunny changed the title fix(cli): update the developing.md.tpl in @sourceloop/cli fix(cli): update the developing.md.tpl in @sourceloop/cli while scaffolding Nov 19, 2024
@yeshamavani
Copy link
Contributor

yeshamavani commented Nov 19, 2024

image image

here mention how one can use npm install via workspaces to install a dependency only in a specific service

@yeshamavani
Copy link
Contributor

yeshamavani commented Nov 19, 2024

image . . why are we referring lb4 command to generate a new service whereas in our cli we have a dedicated command for that

@yeshamavani
Copy link
Contributor

image

all this will already be done via our microservice command

@yeshamavani
Copy link
Contributor

image

instead of this mention about sl update

update the developing.md

791
update developing.md file

791
@yeshamavani yeshamavani merged commit b54465a into master Nov 20, 2024
2 of 4 checks passed
@yeshamavani yeshamavani deleted the gh-791 branch November 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sourceloop/cli generated scaffold has no README and DEVELOPING.md
2 participants