-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FlatFileSchemaResolver
messing up $recursiveRef
#1451
Conversation
c0d2cd7
to
f35abf4
Compare
Signed-off-by: Juan Cruz Viotti <[email protected]>
f35abf4
to
bf3269a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: bf3269a | Previous: d184391 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
403.59032227159634 ns/iter |
399.58213122302766 ns/iter |
1.01 |
JSON_Parse_1 |
32113.95096241791 ns/iter |
30003.61903949606 ns/iter |
1.07 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.99535562086962 ns/iter |
58.85848026286298 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
146.59651369120436 ns/iter |
142.11321440236947 ns/iter |
1.03 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2141052139411648 ns/iter |
2.189630807865952 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1927239742010505 ns/iter |
2.183558722047462 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.1919710926691045 ns/iter |
2.1896521475236463 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.216851960623099 ns/iter |
2.183658941070676 ns/iter |
1.02 |
Regex_Period_Plus |
2.796595104012402 ns/iter |
2.796146832954863 ns/iter |
1.00 |
Regex_Period |
2.803304267498619 ns/iter |
2.795596845015189 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.1079512747733395 ns/iter |
2.800452841505231 ns/iter |
1.11 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.796095748589303 ns/iter |
2.800778190743095 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.7280832229797105 ns/iter |
3.4165440984798168 ns/iter |
1.09 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.417669493860705 ns/iter |
3.4182412670971427 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
12.737046421277956 ns/iter |
12.598976380486443 ns/iter |
1.01 |
Regex_Period_Md_Dollar |
75.77361257806848 ns/iter |
73.55718723497502 ns/iter |
1.03 |
Regex_Caret_Slash_Period_Asterisk |
5.600771704443265 ns/iter |
6.526716240752943 ns/iter |
0.86 |
Regex_Caret_Period_Range_Dollar |
2.799766062450741 ns/iter |
4.044179666166011 ns/iter |
0.69 |
Regex_Nested_Backtrack |
500.5322607416759 ns/iter |
501.238725110218 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.26226655678421 ns/iter |
44.29974011027645 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.78166344947748 ns/iter |
53.71770683150814 ns/iter |
0.98 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.39422889619055 ns/iter |
352.4806809129635 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: bf3269a | Previous: d184391 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
420.35987148476937 ns/iter |
420.2205924451795 ns/iter |
1.00 |
JSON_Parse_1 |
79874.82255255984 ns/iter |
82496.79925003335 ns/iter |
0.97 |
JSON_Fast_Hash_Helm_Chart_Lock |
56.017819999999574 ns/iter |
56.168589999992946 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
216.4687500000184 ns/iter |
217.71468749999912 ns/iter |
0.99 |
Regex_Lower_S_Or_Upper_S_Asterisk |
8.13518701725417 ns/iter |
8.299388802234681 ns/iter |
0.98 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
8.030049071293806 ns/iter |
7.87860532197069 ns/iter |
1.02 |
Regex_Period_Asterisk |
7.843785232839569 ns/iter |
7.827555768626782 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
8.465884783635497 ns/iter |
7.992034785749585 ns/iter |
1.06 |
Regex_Period_Plus |
7.916917410713304 ns/iter |
7.7954972866274375 ns/iter |
1.02 |
Regex_Period |
8.062533446149752 ns/iter |
8.011529017857606 ns/iter |
1.01 |
Regex_Caret_Period_Plus_Dollar |
8.37651558760573 ns/iter |
7.947361571663118 ns/iter |
1.05 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.270322544642486 ns/iter |
8.164461124266426 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
7.8181780900974465 ns/iter |
7.841414697135761 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
8.027556919643075 ns/iter |
7.809782366071818 ns/iter |
1.03 |
Regex_Caret_X_Hyphen |
11.615716071430272 ns/iter |
11.626057142856487 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
141.9724021440926 ns/iter |
145.2839955357023 ns/iter |
0.98 |
Regex_Caret_Slash_Period_Asterisk |
11.56602857142681 ns/iter |
11.64066964285634 ns/iter |
0.99 |
Regex_Caret_Period_Range_Dollar |
9.0309615668268 ns/iter |
8.79170085360943 ns/iter |
1.03 |
Regex_Nested_Backtrack |
589.0144642857008 ns/iter |
600.1979000000119 ns/iter |
0.98 |
Pointer_Object_Traverse |
55.91653571428878 ns/iter |
55.95835714286425 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
76.1153214285721 ns/iter |
76.12581473215943 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
174.17484648491123 ns/iter |
192.9605003142472 ns/iter |
0.90 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: bf3269a | Previous: d184391 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
353.71649648440405 ns/iter |
328.06873246735887 ns/iter |
1.08 |
JSON_Parse_1 |
21543.014753462878 ns/iter |
21136.776493313453 ns/iter |
1.02 |
JSON_Fast_Hash_Helm_Chart_Lock |
50.14066669999693 ns/iter |
47.66116662825274 ns/iter |
1.05 |
JSON_Equality_Helm_Chart_Lock |
140.82498033848637 ns/iter |
129.865169594942 ns/iter |
1.08 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.701962490278674 ns/iter |
1.5667195106423932 ns/iter |
1.09 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.7185259287999226 ns/iter |
1.5769143926940619 ns/iter |
1.09 |
Regex_Period_Asterisk |
1.7157562748831228 ns/iter |
1.5735304543563948 ns/iter |
1.09 |
Regex_Group_Period_Asterisk_Group |
1.7354335395430345 ns/iter |
1.581195775342228 ns/iter |
1.10 |
Regex_Period_Plus |
2.065497867385087 ns/iter |
1.9314783101626407 ns/iter |
1.07 |
Regex_Period |
2.018248059959669 ns/iter |
1.9437535824114465 ns/iter |
1.04 |
Regex_Caret_Period_Plus_Dollar |
2.095428140047902 ns/iter |
1.8838595105698246 ns/iter |
1.11 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.1085760794659167 ns/iter |
1.8801834634149026 ns/iter |
1.12 |
Regex_Caret_Period_Asterisk_Dollar |
1.6683880203013706 ns/iter |
1.5680646024604104 ns/iter |
1.06 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.6614670719751006 ns/iter |
1.610752637317043 ns/iter |
1.03 |
Regex_Caret_X_Hyphen |
6.626362898205288 ns/iter |
6.277444220258353 ns/iter |
1.06 |
Regex_Period_Md_Dollar |
75.8362746322974 ns/iter |
67.42840118216958 ns/iter |
1.12 |
Regex_Caret_Slash_Period_Asterisk |
7.1203756778261615 ns/iter |
5.598378397207209 ns/iter |
1.27 |
Regex_Caret_Period_Range_Dollar |
2.234791850728613 ns/iter |
2.0510619727355097 ns/iter |
1.09 |
Regex_Nested_Backtrack |
793.0149043023456 ns/iter |
728.7528322481498 ns/iter |
1.09 |
Pointer_Object_Traverse |
15.668716108395914 ns/iter |
15.144841120400189 ns/iter |
1.03 |
Pointer_Object_Try_Traverse |
33.75668081022162 ns/iter |
31.48993145366036 ns/iter |
1.07 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
186.74126692888115 ns/iter |
173.20127121718653 ns/iter |
1.08 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: bf3269a | Previous: d184391 | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
44.749253787463765 ns/iter |
43.7842346333813 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
22.58937436771562 ns/iter |
22.428623204220788 ns/iter |
1.01 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
213.13200714696978 ns/iter |
213.22640066846697 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.147358214694922 ns/iter |
2.4872927706219246 ns/iter |
1.27 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.1325709157191075 ns/iter |
2.4870979235541593 ns/iter |
1.26 |
Regex_Period_Asterisk |
3.130472882436479 ns/iter |
2.4886849872073085 ns/iter |
1.26 |
Regex_Group_Period_Asterisk_Group |
3.1553746772030284 ns/iter |
2.4868493715550852 ns/iter |
1.27 |
Regex_Period_Plus |
3.123376925680182 ns/iter |
2.797602223215852 ns/iter |
1.12 |
Regex_Period |
3.1516877564206585 ns/iter |
2.6607959547183517 ns/iter |
1.18 |
Regex_Caret_Period_Plus_Dollar |
3.1224835876696324 ns/iter |
2.487715254512856 ns/iter |
1.26 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.129913128024495 ns/iter |
2.4891886209415444 ns/iter |
1.26 |
Regex_Caret_Period_Asterisk_Dollar |
3.7301655965780167 ns/iter |
2.8017286731204516 ns/iter |
1.33 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.726607760445795 ns/iter |
2.802418754474236 ns/iter |
1.33 |
Regex_Caret_X_Hyphen |
12.427180374120667 ns/iter |
13.054548030456006 ns/iter |
0.95 |
Regex_Period_Md_Dollar |
89.72443398692451 ns/iter |
87.87765552346949 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
7.1465029168189815 ns/iter |
7.154327768073131 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.049273544943923 ns/iter |
4.04245810801691 ns/iter |
1.00 |
Regex_Nested_Backtrack |
822.8422340847178 ns/iter |
822.267300995228 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
384.0947450457124 ns/iter |
378.67999802062815 ns/iter |
1.01 |
JSON_Parse_1 |
32957.33303445128 ns/iter |
33278.647822441766 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.79571868037883 ns/iter |
62.09673042482685 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
142.84080859487023 ns/iter |
146.0086430530994 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]