Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise try_at in JSON #1463

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Optimise try_at in JSON #1463

merged 1 commit into from
Jan 21, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 21, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti jviotti changed the title [WIP] Optimise try_at in JSON Optimise try_at in JSON Jan 21, 2025
@jviotti jviotti marked this pull request as ready for review January 21, 2025 20:20
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 5b85f53 Previous: d3436cf Ratio
JSON_Array_Of_Objects_Unique 425.62873722261924 ns/iter 423.7705615854934 ns/iter 1.00
JSON_Parse_1 26991.35437510489 ns/iter 29922.804748947176 ns/iter 0.90
JSON_Fast_Hash_Helm_Chart_Lock 66.43897080000443 ns/iter 66.50190730695144 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 149.8213495042113 ns/iter 175.2318701128042 ns/iter 0.85
Pointer_Object_Traverse 17.54332688831233 ns/iter 21.48994447892436 ns/iter 0.82
Pointer_Object_Try_Traverse 25.537454092769906 ns/iter 43.262527160606005 ns/iter 0.59
Pointer_Push_Back_Pointer_To_Weak_Pointer 195.12531663486675 ns/iter 244.32518163392535 ns/iter 0.80

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 5b85f53 Previous: d3436cf Ratio
JSON_Array_Of_Objects_Unique 389.0715655577688 ns/iter 439.5780634214989 ns/iter 0.89
JSON_Parse_1 30161.862195386464 ns/iter 30262.67378665774 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 55.32929776955714 ns/iter 55.35855034205425 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 140.3329422801518 ns/iter 143.133154724085 ns/iter 0.98
Pointer_Object_Traverse 44.91256929890167 ns/iter 44.932415088588094 ns/iter 1.00
Pointer_Object_Try_Traverse 52.32997323452825 ns/iter 49.20853205839887 ns/iter 1.06
Pointer_Push_Back_Pointer_To_Weak_Pointer 383.29419193232343 ns/iter 354.222797792722 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 5b85f53 Previous: d3436cf Ratio
JSON_Array_Of_Objects_Unique 504.40389999994295 ns/iter 445.18179370123227 ns/iter 1.13
JSON_Parse_1 80278.37150127026 ns/iter 81457.18750000189 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 65.56392857142157 ns/iter 65.69608035713414 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 197.51052912899382 ns/iter 200.08635715056357 ns/iter 0.99
Pointer_Object_Traverse 49.14284654591706 ns/iter 50.76893000000382 ns/iter 0.97
Pointer_Object_Try_Traverse 71.78292410713486 ns/iter 75.79619419642977 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 177.05093545095906 ns/iter 190.22372234140613 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 5b85f53 Previous: d3436cf Ratio
Pointer_Object_Traverse 44.599867461207815 ns/iter 45.06791787439412 ns/iter 0.99
Pointer_Object_Try_Traverse 22.07607539378525 ns/iter 22.419665198255462 ns/iter 0.98
Pointer_Push_Back_Pointer_To_Weak_Pointer 212.81418771385253 ns/iter 213.65496575871 ns/iter 1.00
JSON_Array_Of_Objects_Unique 401.1558286941427 ns/iter 390.8472011158526 ns/iter 1.03
JSON_Parse_1 33296.482811088244 ns/iter 32399.712312256608 ns/iter 1.03
JSON_Fast_Hash_Helm_Chart_Lock 67.00594792886197 ns/iter 72.05035605357376 ns/iter 0.93
JSON_Equality_Helm_Chart_Lock 139.79334111637758 ns/iter 136.94169315629506 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 39fb009 into main Jan 21, 2025
13 checks passed
@jviotti jviotti deleted the flat-map-try-at branch January 21, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant