Rename project to "Core" #1486
Merged
Rename project to "Core" #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 2218ec9 | Previous: 25c7732 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.210623455849037 ns/iter |
2.181993820538874 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.2177709689994263 ns/iter |
2.177077907827837 ns/iter |
1.02 |
Regex_Period_Asterisk |
2.2102718043495115 ns/iter |
2.1809174422416104 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
2.1989073795271152 ns/iter |
2.1772810402707448 ns/iter |
1.01 |
Regex_Period_Plus |
2.800321803642955 ns/iter |
2.7975844988564624 ns/iter |
1.00 |
Regex_Period |
2.808304225680401 ns/iter |
2.7969594415190673 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
2.8044456077663487 ns/iter |
2.7969556203286277 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.5225057157836783 ns/iter |
2.796720504784179 ns/iter |
0.90 |
Regex_Caret_Period_Asterisk_Dollar |
2.497170040447241 ns/iter |
3.433451500593241 ns/iter |
0.73 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.487174480309116 ns/iter |
3.4258069182518867 ns/iter |
0.73 |
Regex_Caret_X_Hyphen |
12.57309578854681 ns/iter |
12.523264325082303 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
81.35219418814499 ns/iter |
81.17721512844663 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.83823589997511 ns/iter |
6.8377376738749165 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.039217318834373 ns/iter |
4.0435397163846565 ns/iter |
1.00 |
Regex_Nested_Backtrack |
502.5651916940811 ns/iter |
496.9647782709034 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
406.1683351582008 ns/iter |
410.565840079819 ns/iter |
0.99 |
JSON_Parse_1 |
30764.64637769804 ns/iter |
30281.337211816608 ns/iter |
1.02 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.49758237624055 ns/iter |
58.4247273119983 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
147.3591693700624 ns/iter |
151.35329761653338 ns/iter |
0.97 |
JSON_String_Equal/10 |
6.240290324885765 ns/iter |
6.357001437451218 ns/iter |
0.98 |
JSON_String_Equal/100 |
6.645537353273349 ns/iter |
6.538159445778147 ns/iter |
1.02 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9345941866130317 ns/iter |
0.9358319404049869 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.608537194369315 ns/iter |
10.256476882947247 ns/iter |
1.42 |
JSON_String_Fast_Hash/10 |
2.4904540745545463 ns/iter |
2.486280176740598 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.4918907655238045 ns/iter |
2.4861457999653496 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.6942758291265827 ns/iter |
2.1784861312872947 ns/iter |
1.24 |
JSON_String_Key_Hash/100 |
1.867437000801235 ns/iter |
1.8673342063362413 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.9127323545041386 ns/iter |
3.7335846646437147 ns/iter |
1.05 |
JSON_Object_Defines_Miss_Too_Small |
3.7578362360670785 ns/iter |
3.732124503197664 ns/iter |
1.01 |
JSON_Object_Defines_Miss_Too_Large |
3.743550962934109 ns/iter |
3.7333468923177464 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.61375181203603 ns/iter |
44.47468654059776 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.308618330477884 ns/iter |
52.36364316240426 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
289.75222922303607 ns/iter |
346.0390311203587 ns/iter |
0.84 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 2218ec9 | Previous: 25c7732 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.6202064121342423 ns/iter |
2.239731448662294 ns/iter |
0.72 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.6298951011565093 ns/iter |
2.1731349397165367 ns/iter |
0.75 |
Regex_Period_Asterisk |
1.607246107893312 ns/iter |
2.2187470607773685 ns/iter |
0.72 |
Regex_Group_Period_Asterisk_Group |
1.6128260031754025 ns/iter |
2.405942818625018 ns/iter |
0.67 |
Regex_Period_Plus |
1.938914254510851 ns/iter |
2.4354742464044206 ns/iter |
0.80 |
Regex_Period |
1.9283751446179822 ns/iter |
2.9571128905010866 ns/iter |
0.65 |
Regex_Caret_Period_Plus_Dollar |
2.0105859159585036 ns/iter |
2.971099448348263 ns/iter |
0.68 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.9703320441625396 ns/iter |
3.108567091802745 ns/iter |
0.63 |
Regex_Caret_Period_Asterisk_Dollar |
1.6291741782176783 ns/iter |
2.343431552612842 ns/iter |
0.70 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.6215000591609152 ns/iter |
2.618049549863509 ns/iter |
0.62 |
Regex_Caret_X_Hyphen |
6.702044016659698 ns/iter |
9.126104539082466 ns/iter |
0.73 |
Regex_Period_Md_Dollar |
72.56381621647664 ns/iter |
107.71977799045625 ns/iter |
0.67 |
Regex_Caret_Slash_Period_Asterisk |
5.181938974884558 ns/iter |
7.12902157390677 ns/iter |
0.73 |
Regex_Caret_Period_Range_Dollar |
2.23876013698721 ns/iter |
3.1314605679376113 ns/iter |
0.71 |
Regex_Nested_Backtrack |
745.5032415580645 ns/iter |
1034.1907476842046 ns/iter |
0.72 |
JSON_Array_Of_Objects_Unique |
341.4813258105107 ns/iter |
475.5018402696027 ns/iter |
0.72 |
JSON_Parse_1 |
22665.382737137756 ns/iter |
36833.004631038835 ns/iter |
0.62 |
JSON_Fast_Hash_Helm_Chart_Lock |
49.45196545991087 ns/iter |
64.14975537997898 ns/iter |
0.77 |
JSON_Equality_Helm_Chart_Lock |
122.59587380416195 ns/iter |
190.23660766837705 ns/iter |
0.64 |
JSON_String_Equal/10 |
7.737706754013049 ns/iter |
10.0688643324011 ns/iter |
0.77 |
JSON_String_Equal/100 |
6.1689923695183575 ns/iter |
8.32844192677715 ns/iter |
0.74 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.32519599598035254 ns/iter |
0.4102449690428305 ns/iter |
0.79 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.018917998377795 ns/iter |
3.9156191709947485 ns/iter |
0.77 |
JSON_String_Fast_Hash/10 |
1.6430073758124348 ns/iter |
2.5049175532113614 ns/iter |
0.66 |
JSON_String_Fast_Hash/100 |
2.044434150728152 ns/iter |
2.3427240917100924 ns/iter |
0.87 |
JSON_String_Key_Hash/10 |
1.3428365201842263 ns/iter |
1.6154537718296222 ns/iter |
0.83 |
JSON_String_Key_Hash/100 |
1.2775718848074147 ns/iter |
1.5603951017198325 ns/iter |
0.82 |
JSON_Object_Defines_Miss_Same_Length |
2.23635307829629 ns/iter |
3.362106144132075 ns/iter |
0.67 |
JSON_Object_Defines_Miss_Too_Small |
2.226684246525143 ns/iter |
3.7994952091358773 ns/iter |
0.59 |
JSON_Object_Defines_Miss_Too_Large |
2.2451169329390415 ns/iter |
3.356597850615517 ns/iter |
0.67 |
Pointer_Object_Traverse |
16.161949103523266 ns/iter |
19.75359273571819 ns/iter |
0.82 |
Pointer_Object_Try_Traverse |
22.088670470365773 ns/iter |
31.31476993332508 ns/iter |
0.71 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
174.71658183859498 ns/iter |
215.76314284934492 ns/iter |
0.81 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 2218ec9 | Previous: 25c7732 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
6.840515624999861 ns/iter |
6.9144799107156985 ns/iter |
0.99 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
6.854186383928555 ns/iter |
6.835208705357079 ns/iter |
1.00 |
Regex_Period_Asterisk |
7.04527678571384 ns/iter |
6.9091305803554395 ns/iter |
1.02 |
Regex_Group_Period_Asterisk_Group |
6.969931919643203 ns/iter |
7.136781250000215 ns/iter |
0.98 |
Regex_Period_Plus |
7.237206473214337 ns/iter |
7.222527901785521 ns/iter |
1.00 |
Regex_Period |
7.339027901785501 ns/iter |
7.321988839285508 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
7.201361607142179 ns/iter |
7.314254464286003 ns/iter |
0.98 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.348713169641791 ns/iter |
7.436677455357556 ns/iter |
0.99 |
Regex_Caret_Period_Asterisk_Dollar |
7.063945312500509 ns/iter |
7.1376696428591755 ns/iter |
0.99 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
6.951920535714505 ns/iter |
6.848904017857649 ns/iter |
1.02 |
Regex_Caret_X_Hyphen |
14.274044132705036 ns/iter |
14.28854464285629 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
149.0397723642839 ns/iter |
147.26102690802892 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
10.750184375000416 ns/iter |
10.25467343749753 ns/iter |
1.05 |
Regex_Caret_Period_Range_Dollar |
7.647427455357609 ns/iter |
7.46314620535823 ns/iter |
1.02 |
Regex_Nested_Backtrack |
640.3612499999513 ns/iter |
616.5362499999105 ns/iter |
1.04 |
JSON_Array_Of_Objects_Unique |
450.08052676413314 ns/iter |
450.03243079498725 ns/iter |
1.00 |
JSON_Parse_1 |
81315.00000000562 ns/iter |
80977.25446428885 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
69.66683035714334 ns/iter |
66.3701562499952 ns/iter |
1.05 |
JSON_Equality_Helm_Chart_Lock |
200.60650220504857 ns/iter |
199.81075891162672 ns/iter |
1.00 |
JSON_String_Equal/10 |
9.59624192144434 ns/iter |
9.61345977851132 ns/iter |
1.00 |
JSON_String_Equal/100 |
9.996409375000681 ns/iter |
9.930998437496896 ns/iter |
1.01 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.1673909375000022 ns/iter |
2.1670134375000316 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.38463765899804 ns/iter |
14.294910714285031 ns/iter |
1.01 |
JSON_String_Fast_Hash/10 |
3.7219580522194 ns/iter |
3.7161623883922146 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.715322962943995 ns/iter |
3.7196271362156277 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
7.466162946427245 ns/iter |
7.670011160712927 ns/iter |
0.97 |
JSON_String_Key_Hash/100 |
4.02310768575551 ns/iter |
4.030041792910132 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.7279503736388877 ns/iter |
3.7158753736590584 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7209053504971723 ns/iter |
3.7211126719266163 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
4.9577690000000985 ns/iter |
4.959945000000516 ns/iter |
1.00 |
Pointer_Object_Traverse |
52.61020535712645 ns/iter |
53.10589285713263 ns/iter |
0.99 |
Pointer_Object_Try_Traverse |
68.16401785712856 ns/iter |
68.14814732142135 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
161.1619192742599 ns/iter |
162.03533482140082 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 2218ec9 | Previous: 25c7732 | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
49.99606584841999 ns/iter |
48.75109909351417 ns/iter |
1.03 |
Pointer_Object_Try_Traverse |
26.465175487332186 ns/iter |
26.56489624858617 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
137.75989133088126 ns/iter |
137.03136163365616 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
405.59762239883025 ns/iter |
427.453791050745 ns/iter |
0.95 |
JSON_Parse_1 |
33819.50880844205 ns/iter |
34075.01461062306 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.974972296006364 ns/iter |
69.83548164134409 ns/iter |
0.90 |
JSON_Equality_Helm_Chart_Lock |
144.62500186741258 ns/iter |
142.36374623685398 ns/iter |
1.02 |
JSON_String_Equal/10 |
5.98866077485789 ns/iter |
6.129995759782676 ns/iter |
0.98 |
JSON_String_Equal/100 |
6.6133818478572035 ns/iter |
6.614445330744855 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6231730381730735 ns/iter |
0.6240241803090223 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.29995996237376 ns/iter |
14.291537570637741 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9344112480230311 ns/iter |
0.9325220266602526 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9338207841408565 ns/iter |
0.9350672889950257 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.7111787586082579 ns/iter |
1.7110889918549097 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
2.0234223732161145 ns/iter |
2.0241507430891885 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.108811133405616 ns/iter |
3.1110717272690316 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.798256690103177 ns/iter |
2.80074293633738 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
2.489112262805121 ns/iter |
2.4900611471436234 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.7984541489455483 ns/iter |
2.7997003773469666 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.800097903849019 ns/iter |
2.798182696320189 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.8010059429309533 ns/iter |
2.7996558896341583 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.8018336712156287 ns/iter |
2.7991121464627104 ns/iter |
1.00 |
Regex_Period_Plus |
3.422994611025882 ns/iter |
3.4195085996782613 ns/iter |
1.00 |
Regex_Period |
3.418737683333715 ns/iter |
3.4220786606799805 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.4224158322628306 ns/iter |
3.4183441034305027 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.4237185999940554 ns/iter |
3.4178234744280602 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
4.0384161192249675 ns/iter |
4.051101133536011 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.040936949044828 ns/iter |
2.7968561552884674 ns/iter |
1.44 |
Regex_Caret_X_Hyphen |
13.053615828328846 ns/iter |
12.434128917768048 ns/iter |
1.05 |
Regex_Period_Md_Dollar |
94.06755558317371 ns/iter |
93.60875658014514 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
7.299574148543067 ns/iter |
6.531980503840249 ns/iter |
1.12 |
Regex_Caret_Period_Range_Dollar |
3.417874111577566 ns/iter |
4.35126898512985 ns/iter |
0.79 |
Regex_Nested_Backtrack |
832.9628498841207 ns/iter |
824.6474331902422 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: 82d2aae | Previous: 25c7732 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1676309751761464 ns/iter |
2.307258232359736 ns/iter |
0.94 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1797261208008893 ns/iter |
2.4866142250527155 ns/iter |
0.88 |
Regex_Period_Asterisk |
2.5706201568581566 ns/iter |
2.2767789947568207 ns/iter |
1.13 |
Regex_Group_Period_Asterisk_Group |
2.2103886524396983 ns/iter |
2.4229302688969163 ns/iter |
0.91 |
Regex_Period_Plus |
1.8214120008156252 ns/iter |
2.040878574220909 ns/iter |
0.89 |
Regex_Period |
1.8120129569384127 ns/iter |
2.078585156732602 ns/iter |
0.87 |
Regex_Caret_Period_Plus_Dollar |
1.8323298727571904 ns/iter |
2.19364977944299 ns/iter |
0.84 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.7901567261618403 ns/iter |
2.0439360119887415 ns/iter |
0.88 |
Regex_Caret_Period_Asterisk_Dollar |
2.143896132175135 ns/iter |
2.3498742847739904 ns/iter |
0.91 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.1049141509675353 ns/iter |
2.3729913248092065 ns/iter |
0.89 |
Regex_Caret_X_Hyphen |
7.171172839219251 ns/iter |
7.046598025094817 ns/iter |
1.02 |
Regex_Period_Md_Dollar |
81.59055556402602 ns/iter |
92.40012184451756 ns/iter |
0.88 |
Regex_Caret_Slash_Period_Asterisk |
5.152531196083129 ns/iter |
5.31504060787908 ns/iter |
0.97 |
Regex_Caret_Period_Range_Dollar |
2.316123910543976 ns/iter |
2.1873454382733284 ns/iter |
1.06 |
Regex_Nested_Backtrack |
934.1695742840548 ns/iter |
960.6516415210623 ns/iter |
0.97 |
JSON_Array_Of_Objects_Unique |
242.70572003237737 ns/iter |
270.466393366361 ns/iter |
0.90 |
JSON_Parse_1 |
27208.0829860646 ns/iter |
27834.316547057537 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
27.59463876022376 ns/iter |
27.95184948868726 ns/iter |
0.99 |
JSON_Equality_Helm_Chart_Lock |
133.50894567154432 ns/iter |
130.00838687250172 ns/iter |
1.03 |
JSON_String_Equal/10 |
6.134266872621004 ns/iter |
6.298982865014246 ns/iter |
0.97 |
JSON_String_Equal/100 |
6.142962015047435 ns/iter |
6.0395776497263025 ns/iter |
1.02 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.2445517187565096 ns/iter |
0.859495210246331 ns/iter |
1.45 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
4.344164360387627 ns/iter |
4.30433869616401 ns/iter |
1.01 |
JSON_String_Fast_Hash/10 |
2.2139105064864464 ns/iter |
2.0534331171553513 ns/iter |
1.08 |
JSON_String_Fast_Hash/100 |
2.2928447947792137 ns/iter |
2.050799404781123 ns/iter |
1.12 |
JSON_String_Key_Hash/10 |
1.8954039900588964 ns/iter |
1.5785908978959966 ns/iter |
1.20 |
JSON_String_Key_Hash/100 |
2.5428972531948597 ns/iter |
2.065165559893803 ns/iter |
1.23 |
JSON_Object_Defines_Miss_Same_Length |
2.1733053898665995 ns/iter |
2.0133791856408787 ns/iter |
1.08 |
JSON_Object_Defines_Miss_Too_Small |
2.535242487916696 ns/iter |
2.1063131093744354 ns/iter |
1.20 |
JSON_Object_Defines_Miss_Too_Large |
2.3835715350246467 ns/iter |
1.941167571837577 ns/iter |
1.23 |
Pointer_Object_Traverse |
66.35320198932304 ns/iter |
63.42998870938045 ns/iter |
1.05 |
Pointer_Object_Try_Traverse |
44.92426832552092 ns/iter |
41.46197372249117 ns/iter |
1.08 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
218.01189371929001 ns/iter |
189.52957310522316 ns/iter |
1.15 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]