Namespace JSON-related errors #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 4048343 | Previous: d1039b8 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.6385560437378786 ns/iter |
2.272603659912782 ns/iter |
0.72 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.5975293097700836 ns/iter |
2.292447019131944 ns/iter |
0.70 |
Regex_Period_Asterisk |
1.600345243560417 ns/iter |
2.13597649445663 ns/iter |
0.75 |
Regex_Group_Period_Asterisk_Group |
1.5900241355154299 ns/iter |
2.5155558253371537 ns/iter |
0.63 |
Regex_Period_Plus |
1.9453525949889625 ns/iter |
2.9661443190639707 ns/iter |
0.66 |
Regex_Period |
1.906724708066233 ns/iter |
2.9591032337633196 ns/iter |
0.64 |
Regex_Caret_Period_Plus_Dollar |
1.9336218928592854 ns/iter |
2.649880218102814 ns/iter |
0.73 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.900234641780208 ns/iter |
2.899119408415247 ns/iter |
0.66 |
Regex_Caret_Period_Asterisk_Dollar |
1.6579763011206075 ns/iter |
2.588812324057509 ns/iter |
0.64 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.7183960338588529 ns/iter |
2.264736107438064 ns/iter |
0.76 |
Regex_Caret_X_Hyphen |
7.446459543166972 ns/iter |
9.098641882491895 ns/iter |
0.82 |
Regex_Period_Md_Dollar |
75.73138680141207 ns/iter |
100.8998583489317 ns/iter |
0.75 |
Regex_Caret_Slash_Period_Asterisk |
5.224214240855041 ns/iter |
6.378184644628103 ns/iter |
0.82 |
Regex_Caret_Period_Range_Dollar |
2.2337152375469427 ns/iter |
3.1395645799794774 ns/iter |
0.71 |
Regex_Nested_Backtrack |
732.0828276650343 ns/iter |
1047.9826508778744 ns/iter |
0.70 |
JSON_Array_Of_Objects_Unique |
330.60365500978145 ns/iter |
440.1934757700168 ns/iter |
0.75 |
JSON_Parse_1 |
21413.090026645525 ns/iter |
30284.62411968264 ns/iter |
0.71 |
JSON_Fast_Hash_Helm_Chart_Lock |
48.32215506422566 ns/iter |
63.99578752276005 ns/iter |
0.76 |
JSON_Equality_Helm_Chart_Lock |
119.4291334106247 ns/iter |
155.923992024792 ns/iter |
0.77 |
JSON_String_Equal/10 |
8.117813150454584 ns/iter |
10.56912447437271 ns/iter |
0.77 |
JSON_String_Equal/100 |
6.156482826034773 ns/iter |
9.364821301284968 ns/iter |
0.66 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.31699439641369603 ns/iter |
0.41239453396608233 ns/iter |
0.77 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.0042067092803006 ns/iter |
3.8704953860071933 ns/iter |
0.78 |
JSON_String_Fast_Hash/10 |
1.5896856447266632 ns/iter |
2.057935356450222 ns/iter |
0.77 |
JSON_String_Fast_Hash/100 |
1.9294858521699818 ns/iter |
2.4879413451627133 ns/iter |
0.78 |
JSON_String_Key_Hash/10 |
1.2670324164759736 ns/iter |
1.5778325125852966 ns/iter |
0.80 |
JSON_String_Key_Hash/100 |
1.3042938546478358 ns/iter |
1.6773218966140813 ns/iter |
0.78 |
JSON_Object_Defines_Miss_Same_Length |
2.450587206789891 ns/iter |
2.7513182587675784 ns/iter |
0.89 |
JSON_Object_Defines_Miss_Too_Small |
2.2520487058672565 ns/iter |
2.7463315990630255 ns/iter |
0.82 |
JSON_Object_Defines_Miss_Too_Large |
2.281896851726483 ns/iter |
2.815601865018342 ns/iter |
0.81 |
Pointer_Object_Traverse |
18.36500891604446 ns/iter |
22.383229344936808 ns/iter |
0.82 |
Pointer_Object_Try_Traverse |
23.754980490187393 ns/iter |
34.39778225139049 ns/iter |
0.69 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
183.02245358324643 ns/iter |
232.2348523741067 ns/iter |
0.79 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 4048343 | Previous: d1039b8 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.223335079087372 ns/iter |
2.220547577887335 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.237762523620627 ns/iter |
2.247716283883405 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.198775753921563 ns/iter |
2.1938147842379876 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.2166199871210264 ns/iter |
2.201862442030673 ns/iter |
1.01 |
Regex_Period_Plus |
2.8068840050127033 ns/iter |
2.7996738933152243 ns/iter |
1.00 |
Regex_Period |
2.798924834053396 ns/iter |
2.4903684541568527 ns/iter |
1.12 |
Regex_Caret_Period_Plus_Dollar |
2.801007302425068 ns/iter |
2.716484945499371 ns/iter |
1.03 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.79858944417641 ns/iter |
2.488667385071972 ns/iter |
1.12 |
Regex_Caret_Period_Asterisk_Dollar |
3.4198909059283933 ns/iter |
2.2142646830124773 ns/iter |
1.54 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.4184270315627363 ns/iter |
2.193481996152133 ns/iter |
1.56 |
Regex_Caret_X_Hyphen |
13.06624590560709 ns/iter |
13.055306126903075 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
81.87473673647851 ns/iter |
81.58166798897486 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.841055290320265 ns/iter |
5.603774699785185 ns/iter |
1.22 |
Regex_Caret_Period_Range_Dollar |
4.040188980845919 ns/iter |
2.8098367183450117 ns/iter |
1.44 |
Regex_Nested_Backtrack |
519.8770089999698 ns/iter |
502.30239899997287 ns/iter |
1.03 |
JSON_Array_Of_Objects_Unique |
405.7358617052468 ns/iter |
405.55829657041426 ns/iter |
1.00 |
JSON_Parse_1 |
30607.38816392425 ns/iter |
30596.74519791165 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
59.396567391676996 ns/iter |
59.094997287242684 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
151.90687320069088 ns/iter |
151.4245138405844 ns/iter |
1.00 |
JSON_String_Equal/10 |
6.060904682749187 ns/iter |
6.222737949466636 ns/iter |
0.97 |
JSON_String_Equal/100 |
6.539984199139607 ns/iter |
6.848925336962325 ns/iter |
0.95 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9353307705731423 ns/iter |
0.9350277429330012 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.598968796673505 ns/iter |
14.60095197943798 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
2.488282050168437 ns/iter |
2.4859153100512303 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.4870889888227348 ns/iter |
2.486031064618272 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.6534449134646727 ns/iter |
2.654999142447869 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.8685786748195543 ns/iter |
1.8666477267403727 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.734475929639074 ns/iter |
3.733899622256243 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7335919885584223 ns/iter |
3.7334115510541594 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.7379065731373795 ns/iter |
3.736346402134831 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.38457915069174 ns/iter |
44.29840964830761 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.378242278636364 ns/iter |
52.37492310502513 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
308.0246716557839 ns/iter |
306.90642949558656 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 4048343 | Previous: d1039b8 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
6.908577678571654 ns/iter |
6.8718649553569024 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
6.918052201258398 ns/iter |
6.8636571428574 ns/iter |
1.01 |
Regex_Period_Asterisk |
7.04684598214251 ns/iter |
6.974486607142743 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
7.105264508928043 ns/iter |
6.988375000000095 ns/iter |
1.02 |
Regex_Period_Plus |
7.263078985432197 ns/iter |
7.226108258928982 ns/iter |
1.01 |
Regex_Period |
7.169478794642867 ns/iter |
7.387556919643703 ns/iter |
0.97 |
Regex_Caret_Period_Plus_Dollar |
7.158310267857562 ns/iter |
7.135473214286188 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.31648995535699 ns/iter |
7.253243303571974 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
6.9847823660713315 ns/iter |
6.996428571428887 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
6.855889508928316 ns/iter |
6.98299553571502 ns/iter |
0.98 |
Regex_Caret_X_Hyphen |
14.485184533548825 ns/iter |
14.227035204343391 ns/iter |
1.02 |
Regex_Period_Md_Dollar |
152.20895749066315 ns/iter |
150.2891071428536 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
10.243103124999209 ns/iter |
10.38084687499996 ns/iter |
0.99 |
Regex_Caret_Period_Range_Dollar |
7.808334821428938 ns/iter |
7.486743716576887 ns/iter |
1.04 |
Regex_Nested_Backtrack |
624.114732142849 ns/iter |
608.3369642856796 ns/iter |
1.03 |
JSON_Array_Of_Objects_Unique |
496.2864000000309 ns/iter |
491.141263845394 ns/iter |
1.01 |
JSON_Parse_1 |
80555.9263392906 ns/iter |
79810.91517857816 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
68.79581249999133 ns/iter |
66.33134821427689 ns/iter |
1.04 |
JSON_Equality_Helm_Chart_Lock |
189.061302594776 ns/iter |
188.36602574697568 ns/iter |
1.00 |
JSON_String_Equal/10 |
8.981233888476547 ns/iter |
8.985188616071735 ns/iter |
1.00 |
JSON_String_Equal/100 |
9.940403527050933 ns/iter |
9.92287897355859 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.1678693749997535 ns/iter |
2.174887500000011 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
15.487265624999836 ns/iter |
14.828819196429167 ns/iter |
1.04 |
JSON_String_Fast_Hash/10 |
4.0255724625452745 ns/iter |
4.041466123288193 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
4.023914962543068 ns/iter |
4.028135319692967 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
7.769237723214774 ns/iter |
7.935802196715434 ns/iter |
0.98 |
JSON_String_Key_Hash/100 |
4.024343191963986 ns/iter |
4.035108310776726 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.7198366005002566 ns/iter |
3.7559480290077483 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Too_Small |
4.960667000000285 ns/iter |
4.967442857143567 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.4078363331999295 ns/iter |
3.4380607974321817 ns/iter |
0.99 |
Pointer_Object_Traverse |
50.240229999997155 ns/iter |
49.39659000000347 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
67.83926785714252 ns/iter |
67.81262276785834 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
161.1840178571506 ns/iter |
162.48794642856572 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 4048343 | Previous: d1039b8 | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
47.7083768847123 ns/iter |
45.64983324736455 ns/iter |
1.05 |
Pointer_Object_Try_Traverse |
26.134746410513166 ns/iter |
26.14561696173193 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
144.9213851306606 ns/iter |
144.98700164498874 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
411.967367548522 ns/iter |
414.4424439435892 ns/iter |
0.99 |
JSON_Parse_1 |
33341.792799205316 ns/iter |
33488.16770838592 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.79723889855444 ns/iter |
62.86977271866869 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
149.06502971150493 ns/iter |
150.91060489094605 ns/iter |
0.99 |
JSON_String_Equal/10 |
6.345571332628033 ns/iter |
6.33749663091924 ns/iter |
1.00 |
JSON_String_Equal/100 |
6.962461328538639 ns/iter |
6.967756830455331 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9340861029922098 ns/iter |
0.9336441250683972 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.286071668347253 ns/iter |
14.288750528005046 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9329964569101395 ns/iter |
0.9328878806972629 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9323074512585936 ns/iter |
0.9322742114096909 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.6718799712044443 ns/iter |
1.6761272356245651 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.9848824361366908 ns/iter |
1.9835455350792497 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
2.4875001097746368 ns/iter |
2.661097417192496 ns/iter |
0.93 |
JSON_Object_Defines_Miss_Too_Small |
2.4888357205683245 ns/iter |
2.4959629192068467 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.116717937619878 ns/iter |
3.1085096648253177 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.420751422906558 ns/iter |
3.4198403515840377 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.4511782856901467 ns/iter |
3.4288885296590075 ns/iter |
1.01 |
Regex_Period_Asterisk |
3.419455358295965 ns/iter |
3.4215930773693723 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
3.4285873563159743 ns/iter |
3.4254047160594197 ns/iter |
1.00 |
Regex_Period_Plus |
3.72683419454435 ns/iter |
3.7345131097394084 ns/iter |
1.00 |
Regex_Period |
3.732960856892575 ns/iter |
3.7305413376614265 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.733985750013824 ns/iter |
3.7342162475184466 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.736621156901315 ns/iter |
4.215419201107587 ns/iter |
0.89 |
Regex_Caret_Period_Asterisk_Dollar |
4.670233452405168 ns/iter |
4.661344183754675 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.667548452307231 ns/iter |
4.660717727100717 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
12.431066286467704 ns/iter |
13.143488127108597 ns/iter |
0.95 |
Regex_Period_Md_Dollar |
90.07581565558654 ns/iter |
93.38737598994702 ns/iter |
0.96 |
Regex_Caret_Slash_Period_Asterisk |
8.084589777760979 ns/iter |
8.08867601860652 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.661368780524232 ns/iter |
4.68489834175964 ns/iter |
0.99 |
Regex_Nested_Backtrack |
818.021228166911 ns/iter |
823.6360329232282 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: 4048343 | Previous: d1039b8 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.027769776759469 ns/iter |
2.4195720697651444 ns/iter |
0.84 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.0203703413431 ns/iter |
2.3174542852993736 ns/iter |
0.87 |
Regex_Period_Asterisk |
2.018095565111979 ns/iter |
2.34573295774675 ns/iter |
0.86 |
Regex_Group_Period_Asterisk_Group |
2.04476939104078 ns/iter |
2.392394755450172 ns/iter |
0.85 |
Regex_Period_Plus |
2.105221837662252 ns/iter |
1.9970364152816449 ns/iter |
1.05 |
Regex_Period |
2.2655364743873743 ns/iter |
2.0219891210105225 ns/iter |
1.12 |
Regex_Caret_Period_Plus_Dollar |
2.0162298777917127 ns/iter |
1.9939159830868136 ns/iter |
1.01 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.0178136969131835 ns/iter |
2.1077153542634384 ns/iter |
0.96 |
Regex_Caret_Period_Asterisk_Dollar |
2.014936340560062 ns/iter |
2.353490441479331 ns/iter |
0.86 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.365204111633083 ns/iter |
2.682683548533442 ns/iter |
0.88 |
Regex_Caret_X_Hyphen |
6.483633421100743 ns/iter |
6.906095276325223 ns/iter |
0.94 |
Regex_Period_Md_Dollar |
76.47345072446501 ns/iter |
73.29214143605276 ns/iter |
1.04 |
Regex_Caret_Slash_Period_Asterisk |
4.821641256639517 ns/iter |
5.11486335625981 ns/iter |
0.94 |
Regex_Caret_Period_Range_Dollar |
2.17413655197686 ns/iter |
2.3275476075501382 ns/iter |
0.93 |
Regex_Nested_Backtrack |
885.7349837288618 ns/iter |
867.4661879869855 ns/iter |
1.02 |
JSON_Array_Of_Objects_Unique |
216.67345545964216 ns/iter |
213.24683500663022 ns/iter |
1.02 |
JSON_Parse_1 |
24473.595888205753 ns/iter |
24996.58601164034 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
25.046840205809616 ns/iter |
25.106959900570214 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
122.44334578882642 ns/iter |
121.97786776868148 ns/iter |
1.00 |
JSON_String_Equal/10 |
5.7608221402220545 ns/iter |
5.758435847668455 ns/iter |
1.00 |
JSON_String_Equal/100 |
5.414969248741629 ns/iter |
5.486693152532578 ns/iter |
0.99 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.8323093261195088 ns/iter |
0.797841942657607 ns/iter |
1.04 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.7047300648037393 ns/iter |
3.7041075376409105 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
2.0264901542855243 ns/iter |
2.0221980617441124 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.032073379152041 ns/iter |
2.023561221865578 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.5362682202500169 ns/iter |
1.5005616754259958 ns/iter |
1.02 |
JSON_String_Key_Hash/100 |
2.054851052581718 ns/iter |
2.069351140277079 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Same_Length |
1.9704831397946134 ns/iter |
1.8334778564425385 ns/iter |
1.07 |
JSON_Object_Defines_Miss_Too_Small |
2.0156228844949626 ns/iter |
2.0728651951016746 ns/iter |
0.97 |
JSON_Object_Defines_Miss_Too_Large |
1.8501451386008125 ns/iter |
1.876194814754322 ns/iter |
0.99 |
Pointer_Object_Traverse |
57.66425416518666 ns/iter |
59.14382191972436 ns/iter |
0.97 |
Pointer_Object_Try_Traverse |
41.69145773521927 ns/iter |
38.44343493689406 ns/iter |
1.08 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
174.80634914599605 ns/iter |
186.46083669995804 ns/iter |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]