Skip to content

Commit

Permalink
Upgrade Noa to the latest version (#1461)
Browse files Browse the repository at this point in the history
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
jviotti authored Jan 21, 2025
1 parent 60a3862 commit cd623c4
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 35 deletions.
2 changes: 1 addition & 1 deletion DEPENDENCIES
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
vendorpull https://github.com/sourcemeta/vendorpull 70342aaf458e6cb80baeb5b718901075fc42ede6
noa https://github.com/sourcemeta/noa a8d36453236abc365f08a76a486f92c84f976fd9
noa https://github.com/sourcemeta/noa dee6c859895baf918fe3ecca22e4e7a262c5d500
jsontestsuite https://github.com/nst/JSONTestSuite d64aefb55228d9584d3e5b2433f720ea8fd00c82
jsonschema-2020-12 https://github.com/json-schema-org/json-schema-spec 769daad75a9553562333a8937a187741cb708c72
jsonschema-2019-09 https://github.com/json-schema-org/json-schema-spec 41014ea723120ce70b314d72f863c6929d9f3cfd
Expand Down
1 change: 1 addition & 0 deletions cmake/FindNoa.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ if(NOT Noa_FOUND)
set(NOA_GOOGLETEST ${JSONTOOLKIT_TESTS} CACHE BOOL "GoogleTest")
set(NOA_GOOGLEBENCHMARK ${JSONTOOLKIT_BENCHMARK} CACHE BOOL "GoogleBenchmark")
add_subdirectory("${PROJECT_SOURCE_DIR}/vendor/noa")
include("${PROJECT_SOURCE_DIR}/vendor/noa/cmake/noa.cmake")
set(Noa_FOUND ON)
endif()
1 change: 0 additions & 1 deletion vendor/noa/CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 22 additions & 22 deletions vendor/noa/cmake/noa/defaults.cmake

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/noa/cmake/noa/shim.cmake

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vendor/noa/cmake/noa/variables.cmake

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions vendor/noa/src/flat_map/CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions vendor/noa/src/hash/CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions vendor/noa/src/regex/CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 comments on commit cd623c4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: cd623c4 Previous: 60a3862 Ratio
JSON_Array_Of_Objects_Unique 401.1147872576045 ns/iter 444.68250237895023 ns/iter 0.90
JSON_Parse_1 24628.32681867625 ns/iter 32452.946257874497 ns/iter 0.76
JSON_Fast_Hash_Helm_Chart_Lock 55.78855703756165 ns/iter 63.44555534693963 ns/iter 0.88
JSON_Equality_Helm_Chart_Lock 154.91709954526158 ns/iter 181.7220861256914 ns/iter 0.85
Pointer_Object_Traverse 20.17496196977734 ns/iter 35.88328919060362 ns/iter 0.56
Pointer_Object_Try_Traverse 36.27885549928748 ns/iter 61.9215569972753 ns/iter 0.59
Pointer_Push_Back_Pointer_To_Weak_Pointer 201.79698766804069 ns/iter 261.1113437089861 ns/iter 0.77

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: cd623c4 Previous: 60a3862 Ratio
JSON_Array_Of_Objects_Unique 449.33601736923373 ns/iter 439.47004632904265 ns/iter 1.02
JSON_Parse_1 30156.467458944066 ns/iter 30683.498603171654 ns/iter 0.98
JSON_Fast_Hash_Helm_Chart_Lock 55.32131747802451 ns/iter 61.447779846879925 ns/iter 0.90
JSON_Equality_Helm_Chart_Lock 138.31156464084108 ns/iter 144.825290346911 ns/iter 0.96
Pointer_Object_Traverse 44.98762692182171 ns/iter 46.42137573117939 ns/iter 0.97
Pointer_Object_Try_Traverse 50.01374109999688 ns/iter 49.16805703955921 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.5677761250012 ns/iter 352.6654672668451 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: cd623c4 Previous: 60a3862 Ratio
JSON_Array_Of_Objects_Unique 446.9065811857618 ns/iter 453.00221124941567 ns/iter 0.99
JSON_Parse_1 79723.01339285487 ns/iter 79717.62421320713 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 70.02922991072222 ns/iter 64.7559464285763 ns/iter 1.08
JSON_Equality_Helm_Chart_Lock 195.21748012422222 ns/iter 211.1512428057492 ns/iter 0.92
Pointer_Object_Traverse 50.632260000008955 ns/iter 50.79133000000411 ns/iter 1.00
Pointer_Object_Try_Traverse 76.03314732143676 ns/iter 76.19808035714064 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 178.8504534688098 ns/iter 181.15780188909045 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: cd623c4 Previous: 60a3862 Ratio
Pointer_Object_Traverse 44.69701046021094 ns/iter 70.61938036311122 ns/iter 0.63
Pointer_Object_Try_Traverse 22.420786335936146 ns/iter 53.66880193035658 ns/iter 0.42
Pointer_Push_Back_Pointer_To_Weak_Pointer 214.40573691616103 ns/iter 214.25428741475832 ns/iter 1.00
JSON_Array_Of_Objects_Unique 399.03176446057 ns/iter 307.02101472831015 ns/iter 1.30
JSON_Parse_1 32761.511638886124 ns/iter 33563.26670962864 ns/iter 0.98
JSON_Fast_Hash_Helm_Chart_Lock 72.00111306038184 ns/iter 37.384280120999954 ns/iter 1.93
JSON_Equality_Helm_Chart_Lock 154.31607213077748 ns/iter 145.03757520464285 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.