Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reidentify() work even with top-level $ref #1422

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Make reidentify() work even with top-level $ref #1422

merged 1 commit into from
Jan 6, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 6, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti marked this pull request as ready for review January 6, 2025 17:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: ef5b451 Previous: b3a208d Ratio
JSON_Array_Of_Objects_Unique 330.870272652758 ns/iter 388.3547347296708 ns/iter 0.85
JSON_Parse_1 21478.37027560083 ns/iter 24593.317760815295 ns/iter 0.87
JSON_Fast_Hash_Helm_Chart_Lock 47.66615752677478 ns/iter 58.545023577415286 ns/iter 0.81
JSON_Equality_Helm_Chart_Lock 137.62899033471177 ns/iter 148.4749491930972 ns/iter 0.93
Regex_Lower_S_Or_Upper_S_Asterisk 1.5676359920697156 ns/iter 1.719109787862507 ns/iter 0.91
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.5917234899035377 ns/iter 1.7953203700805556 ns/iter 0.89
Regex_Period_Asterisk 1.5745426623539638 ns/iter 1.7820022235608939 ns/iter 0.88
Regex_Group_Period_Asterisk_Group 1.568133449142823 ns/iter 1.7994713276109702 ns/iter 0.87
Regex_Period_Plus 1.8849466180901115 ns/iter 2.180514648595153 ns/iter 0.86
Regex_Period 1.8812763432084691 ns/iter 2.1915495853826847 ns/iter 0.86
Regex_Caret_Period_Plus_Dollar 1.8869265268211677 ns/iter 2.1299995452718052 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 1.9048176130289283 ns/iter 2.1227368247285763 ns/iter 0.90
Regex_Caret_Period_Asterisk_Dollar 1.5708585265496977 ns/iter 1.8125836474450305 ns/iter 0.87
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.577292172700421 ns/iter 1.8456102863971515 ns/iter 0.85
Regex_Caret_X_Hyphen 6.272727333770585 ns/iter 6.935337984107705 ns/iter 0.90
Regex_Period_Md_Dollar 67.34984434728092 ns/iter 79.50944666746975 ns/iter 0.85
Regex_Caret_Slash_Period_Asterisk 5.286076012918043 ns/iter 7.311963883187427 ns/iter 0.72
Regex_Caret_Period_Range_Dollar 2.038118072122529 ns/iter 2.236217299441727 ns/iter 0.91
Regex_Nested_Backtrack 726.1711425925109 ns/iter 807.2955664750376 ns/iter 0.90
Pointer_Object_Traverse 14.778374755966084 ns/iter 16.02090361945681 ns/iter 0.92
Pointer_Object_Try_Traverse 31.313479368986616 ns/iter 34.536290676619224 ns/iter 0.91
Pointer_Push_Back_Pointer_To_Weak_Pointer 170.66358853019585 ns/iter 198.01715156545967 ns/iter 0.86

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: ef5b451 Previous: b3a208d Ratio
JSON_Array_Of_Objects_Unique 442.02380784665496 ns/iter 443.8216909718648 ns/iter 1.00
JSON_Parse_1 30808.609792678188 ns/iter 30870.327975979046 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 54.6853268166222 ns/iter 54.807580190187196 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 149.3478938470069 ns/iter 149.31430527388156 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.486483429344455 ns/iter 2.204875721950247 ns/iter 1.13
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1782046495022285 ns/iter 2.1928518973772166 ns/iter 0.99
Regex_Period_Asterisk 2.4879984266174886 ns/iter 2.19866263447157 ns/iter 1.13
Regex_Group_Period_Asterisk_Group 2.1832438490880937 ns/iter 2.202792555923439 ns/iter 0.99
Regex_Period_Plus 2.7970695870307622 ns/iter 2.486444520734314 ns/iter 1.12
Regex_Period 2.488778575661826 ns/iter 2.506823397558652 ns/iter 0.99
Regex_Caret_Period_Plus_Dollar 2.486592530396397 ns/iter 2.4891329500093318 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.488916835246118 ns/iter 2.4865027104304285 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.4173117017990635 ns/iter 3.417071023765133 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.418740402881752 ns/iter 3.417194620003428 ns/iter 1.00
Regex_Caret_X_Hyphen 13.05121261325549 ns/iter 7.461082750338184 ns/iter 1.75
Regex_Period_Md_Dollar 74.54320903090799 ns/iter 74.71244249975501 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.15789556523388 ns/iter 7.147608018317036 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.7313025095472945 ns/iter 3.728394814670792 ns/iter 1.00
Regex_Nested_Backtrack 496.115831131216 ns/iter 493.96259124150424 ns/iter 1.00
Pointer_Object_Traverse 44.9631726570251 ns/iter 44.81471572939452 ns/iter 1.00
Pointer_Object_Try_Traverse 52.28236739236166 ns/iter 52.38450672696248 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.0548500761233 ns/iter 352.9591835293568 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: ef5b451 Previous: b3a208d Ratio
JSON_Array_Of_Objects_Unique 420.56809696378986 ns/iter 419.47351197132787 ns/iter 1.00
JSON_Parse_1 84396.0156250085 ns/iter 79436.81532074645 ns/iter 1.06
JSON_Fast_Hash_Helm_Chart_Lock 58.06281249999553 ns/iter 52.2561200000041 ns/iter 1.11
JSON_Equality_Helm_Chart_Lock 216.63406249999184 ns/iter 220.12059375001058 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 8.145545758928563 ns/iter 8.16581915997396 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.019853089197694 ns/iter 7.9006350446420015 ns/iter 1.02
Regex_Period_Asterisk 7.929050223215281 ns/iter 7.895462911179545 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 8.289235677280216 ns/iter 7.849104875673845 ns/iter 1.06
Regex_Period_Plus 7.790706661647368 ns/iter 7.786670054523892 ns/iter 1.00
Regex_Period 8.00145424107081 ns/iter 7.886783000505064 ns/iter 1.01
Regex_Caret_Period_Plus_Dollar 7.759733001072059 ns/iter 7.904286125427345 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 8.138853794642996 ns/iter 8.10100576740719 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 7.7898761160710706 ns/iter 7.863545054179978 ns/iter 0.99
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.820890143656772 ns/iter 7.877563616071218 ns/iter 0.99
Regex_Caret_X_Hyphen 11.613690349939734 ns/iter 11.871144642857498 ns/iter 0.98
Regex_Period_Md_Dollar 142.2900137370538 ns/iter 142.7856364827829 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 11.765919642856813 ns/iter 11.739018749999275 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 9.060904687499871 ns/iter 8.727760675322878 ns/iter 1.04
Regex_Nested_Backtrack 593.983900000012 ns/iter 588.2827678570987 ns/iter 1.01
Pointer_Object_Traverse 56.036419999998095 ns/iter 56.780030000004444 ns/iter 0.99
Pointer_Object_Try_Traverse 76.07697544642633 ns/iter 75.86959821429063 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 180.31729109266234 ns/iter 182.80445382182648 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: ef5b451 Previous: b3a208d Ratio
Pointer_Object_Traverse 43.98033322448431 ns/iter 44.755567175655656 ns/iter 0.98
Pointer_Object_Try_Traverse 22.487684460212584 ns/iter 22.434193227016205 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.34041140592623 ns/iter 214.67710321269962 ns/iter 0.99
Regex_Lower_S_Or_Upper_S_Asterisk 2.492810003344508 ns/iter 3.126022176619008 ns/iter 0.80
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4879159289365393 ns/iter 3.1305882731536867 ns/iter 0.79
Regex_Period_Asterisk 2.4899438686035418 ns/iter 3.123425530322061 ns/iter 0.80
Regex_Group_Period_Asterisk_Group 2.488208272359971 ns/iter 3.1298497215982115 ns/iter 0.79
Regex_Period_Plus 2.7990211734263 ns/iter 3.122830425844465 ns/iter 0.90
Regex_Period 2.7972905830047434 ns/iter 3.1234952580334596 ns/iter 0.90
Regex_Caret_Period_Plus_Dollar 2.7983439951139775 ns/iter 3.1286515476959122 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 2.796867822743333 ns/iter 3.1571107485885914 ns/iter 0.89
Regex_Caret_Period_Asterisk_Dollar 3.7279153059905314 ns/iter 3.733453373388718 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.7283340975285237 ns/iter 3.73085095616093 ns/iter 1.00
Regex_Caret_X_Hyphen 12.439224876358839 ns/iter 12.428559836232674 ns/iter 1.00
Regex_Period_Md_Dollar 88.00060263672238 ns/iter 90.09064432168736 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 7.152353133692239 ns/iter 7.14730105289689 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 2.810802922699369 ns/iter 4.04044961193531 ns/iter 0.70
Regex_Nested_Backtrack 812.9444037980155 ns/iter 812.6147451917195 ns/iter 1.00
JSON_Array_Of_Objects_Unique 378.71173210011835 ns/iter 382.4648036039672 ns/iter 0.99
JSON_Parse_1 32796.91549361811 ns/iter 32924.76700720282 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 62.46865619113089 ns/iter 62.78438304285357 ns/iter 0.99
JSON_Equality_Helm_Chart_Lock 155.60501361204854 ns/iter 143.8481141125099 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 69d5a7a into main Jan 6, 2025
13 checks passed
@jviotti jviotti deleted the ref-allof branch January 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant