Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relativize() mistreating relative references with .. #1427

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 9, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: d40a25f Previous: 73da160 Ratio
JSON_Array_Of_Objects_Unique 431.3799223914656 ns/iter 445.5113323362429 ns/iter 0.97
JSON_Parse_1 30963.687079942534 ns/iter 30099.675387056577 ns/iter 1.03
JSON_Fast_Hash_Helm_Chart_Lock 54.72313575313564 ns/iter 54.7363081394045 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 149.0737445113874 ns/iter 147.83038994799298 ns/iter 1.01
Regex_Lower_S_Or_Upper_S_Asterisk 2.4869818452922474 ns/iter 2.221323262614719 ns/iter 1.12
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.278061729872323 ns/iter 2.196563147580705 ns/iter 1.04
Regex_Period_Asterisk 2.4861359872599897 ns/iter 2.2481177012939497 ns/iter 1.11
Regex_Group_Period_Asterisk_Group 2.205366940498892 ns/iter 2.1910879530301206 ns/iter 1.01
Regex_Period_Plus 2.805509723202466 ns/iter 2.2445505775899846 ns/iter 1.25
Regex_Period 2.486456716513008 ns/iter 2.268876420618933 ns/iter 1.10
Regex_Caret_Period_Plus_Dollar 2.342359295612865 ns/iter 2.2712866095868023 ns/iter 1.03
Regex_Caret_Group_Period_Plus_Group_Dollar 2.2047284542188765 ns/iter 2.240255307963727 ns/iter 0.98
Regex_Caret_Period_Asterisk_Dollar 2.488803762305638 ns/iter 2.4873597153191302 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.4884240358291922 ns/iter 2.486581096661786 ns/iter 1.00
Regex_Caret_X_Hyphen 13.056510845816824 ns/iter 13.053888967633638 ns/iter 1.00
Regex_Period_Md_Dollar 76.37688861331426 ns/iter 73.5545436709492 ns/iter 1.04
Regex_Caret_Slash_Period_Asterisk 7.147185585703759 ns/iter 7.149032287313548 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.7292722195386068 ns/iter 3.731257996212018 ns/iter 1.00
Regex_Nested_Backtrack 494.74927856565984 ns/iter 488.9311626692607 ns/iter 1.01
Pointer_Object_Traverse 44.873085645230645 ns/iter 47.29454536773934 ns/iter 0.95
Pointer_Object_Try_Traverse 52.28419394157388 ns/iter 52.30499678541657 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 353.4958498893667 ns/iter 354.4760693065961 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: d40a25f Previous: 73da160 Ratio
JSON_Array_Of_Objects_Unique 352.67581961071494 ns/iter 345.7143085267733 ns/iter 1.02
JSON_Parse_1 22711.980226807173 ns/iter 23845.46367664171 ns/iter 0.95
JSON_Fast_Hash_Helm_Chart_Lock 50.189220356089976 ns/iter 57.68083570966103 ns/iter 0.87
JSON_Equality_Helm_Chart_Lock 137.28961483397526 ns/iter 192.64906017398366 ns/iter 0.71
Regex_Lower_S_Or_Upper_S_Asterisk 1.666908494872669 ns/iter 1.6569129708125556 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.6058097327441225 ns/iter 1.6099077679600693 ns/iter 1.00
Regex_Period_Asterisk 1.6109093182161376 ns/iter 1.6694413229972065 ns/iter 0.96
Regex_Group_Period_Asterisk_Group 1.6723945504564872 ns/iter 1.6353829299912856 ns/iter 1.02
Regex_Period_Plus 2.415554047713341 ns/iter 1.9351494303879735 ns/iter 1.25
Regex_Period 1.927361836236202 ns/iter 1.9176914364979336 ns/iter 1.01
Regex_Caret_Period_Plus_Dollar 2.0405562707820324 ns/iter 1.9263000932549585 ns/iter 1.06
Regex_Caret_Group_Period_Plus_Group_Dollar 1.9748669345819028 ns/iter 1.9498481741570943 ns/iter 1.01
Regex_Caret_Period_Asterisk_Dollar 1.7703112777431111 ns/iter 1.609106765297031 ns/iter 1.10
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.889166021918751 ns/iter 1.616113680289769 ns/iter 1.17
Regex_Caret_X_Hyphen 7.454580002033879 ns/iter 6.350501950711262 ns/iter 1.17
Regex_Period_Md_Dollar 76.4239926727871 ns/iter 82.10288452046241 ns/iter 0.93
Regex_Caret_Slash_Period_Asterisk 5.939565395451015 ns/iter 7.142018477298771 ns/iter 0.83
Regex_Caret_Period_Range_Dollar 2.1876504375533794 ns/iter 2.1003139590070443 ns/iter 1.04
Regex_Nested_Backtrack 789.5239170767082 ns/iter 778.4608807946346 ns/iter 1.01
Pointer_Object_Traverse 16.46734438955037 ns/iter 15.224232345362308 ns/iter 1.08
Pointer_Object_Try_Traverse 33.635620702516206 ns/iter 32.55358989989005 ns/iter 1.03
Pointer_Push_Back_Pointer_To_Weak_Pointer 189.15649968882988 ns/iter 173.49714416704595 ns/iter 1.09

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: d40a25f Previous: 73da160 Ratio
JSON_Array_Of_Objects_Unique 420.4971014169836 ns/iter 417.86640904164796 ns/iter 1.01
JSON_Parse_1 80035.15625000394 ns/iter 80220.21205356112 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 53.967196428571036 ns/iter 54.22493000000941 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 223.28068749999375 ns/iter 218.4062581068665 ns/iter 1.02
Regex_Lower_S_Or_Upper_S_Asterisk 8.238729873934332 ns/iter 8.213707999045111 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.812343750000902 ns/iter 8.281220982142251 ns/iter 0.94
Regex_Period_Asterisk 8.091670758928313 ns/iter 7.836212911445954 ns/iter 1.03
Regex_Group_Period_Asterisk_Group 8.115993303572061 ns/iter 7.847654017857205 ns/iter 1.03
Regex_Period_Plus 7.963891741071499 ns/iter 8.31999103428547 ns/iter 0.96
Regex_Period 7.880787946428214 ns/iter 7.829474330358315 ns/iter 1.01
Regex_Caret_Period_Plus_Dollar 7.9279799107137965 ns/iter 8.324883444979417 ns/iter 0.95
Regex_Caret_Group_Period_Plus_Group_Dollar 8.171813802804738 ns/iter 8.636710675729622 ns/iter 0.95
Regex_Caret_Period_Asterisk_Dollar 8.150704241071592 ns/iter 8.674525407703355 ns/iter 0.94
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.95761495535682 ns/iter 7.808164250855988 ns/iter 1.02
Regex_Caret_X_Hyphen 11.697258928571891 ns/iter 11.552719642858326 ns/iter 1.01
Regex_Period_Md_Dollar 143.75703376085502 ns/iter 142.00484633907078 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 11.655519642857826 ns/iter 12.053517187499807 ns/iter 0.97
Regex_Caret_Period_Range_Dollar 8.708908889692843 ns/iter 8.942676562499585 ns/iter 0.97
Regex_Nested_Backtrack 592.1503571427828 ns/iter 593.7655999999834 ns/iter 1.00
Pointer_Object_Traverse 55.88525892857125 ns/iter 56.1860089285712 ns/iter 0.99
Pointer_Object_Try_Traverse 76.06185267857565 ns/iter 75.9408147321418 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 196.06715196127965 ns/iter 175.49091800161145 ns/iter 1.12

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: d40a25f Previous: 73da160 Ratio
Pointer_Object_Traverse 44.45481973391887 ns/iter 45.419092692203726 ns/iter 0.98
Pointer_Object_Try_Traverse 22.438167592692746 ns/iter 22.408976111966304 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 215.57718431366953 ns/iter 213.18366927426004 ns/iter 1.01
Regex_Lower_S_Or_Upper_S_Asterisk 2.487737684934027 ns/iter 3.1176807050833037 ns/iter 0.80
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4869254834450554 ns/iter 3.1298307012183457 ns/iter 0.79
Regex_Period_Asterisk 2.4916528439814467 ns/iter 3.127880919446214 ns/iter 0.80
Regex_Group_Period_Asterisk_Group 2.4856525023078273 ns/iter 3.1357454873595496 ns/iter 0.79
Regex_Period_Plus 2.797410365746422 ns/iter 3.1231723051186915 ns/iter 0.90
Regex_Period 2.8041479593520577 ns/iter 3.1228548339147246 ns/iter 0.90
Regex_Caret_Period_Plus_Dollar 2.798963977289171 ns/iter 3.1288562067726806 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 2.799242673395979 ns/iter 3.1328709272297153 ns/iter 0.89
Regex_Caret_Period_Asterisk_Dollar 3.729998414899067 ns/iter 3.1246290860992465 ns/iter 1.19
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.729771847709212 ns/iter 3.13493101246359 ns/iter 1.19
Regex_Caret_X_Hyphen 12.426764808327611 ns/iter 12.434664312759386 ns/iter 1.00
Regex_Period_Md_Dollar 89.24575264809111 ns/iter 89.39581191582279 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 6.118215204748513 ns/iter 7.1537896883511065 ns/iter 0.86
Regex_Caret_Period_Range_Dollar 3.1093460430347313 ns/iter 4.040002535840099 ns/iter 0.77
Regex_Nested_Backtrack 812.2959861617298 ns/iter 823.780254998226 ns/iter 0.99
JSON_Array_Of_Objects_Unique 382.29711240234263 ns/iter 406.0370539277187 ns/iter 0.94
JSON_Parse_1 32516.65102653263 ns/iter 32716.600132281983 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 63.329729962560855 ns/iter 64.77728833891042 ns/iter 0.98
JSON_Equality_Helm_Chart_Lock 142.26940384991437 ns/iter 142.8045102793396 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 2ff048e into main Jan 9, 2025
13 checks passed
@jviotti jviotti deleted the fix-relativize branch January 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant