Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract BundleOptions::WithoutIdentifiers into its own unidentify() #1429

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 10, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: c0e816c Previous: 16adce4 Ratio
JSON_Array_Of_Objects_Unique 453.973472754622 ns/iter 448.4770890754095 ns/iter 1.01
JSON_Parse_1 30627.363055653022 ns/iter 30090.83903109611 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 54.689362608498975 ns/iter 54.68786174052018 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 150.04622729355802 ns/iter 148.96340890249002 ns/iter 1.01
Regex_Lower_S_Or_Upper_S_Asterisk 2.2126335645021507 ns/iter 2.1981092509955573 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1961872146912893 ns/iter 2.183798040079222 ns/iter 1.01
Regex_Period_Asterisk 2.2082445432868956 ns/iter 2.179099111927257 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 2.209861847338464 ns/iter 2.1886055407645943 ns/iter 1.01
Regex_Period_Plus 2.488360799216647 ns/iter 2.4881015864876015 ns/iter 1.00
Regex_Period 2.486450756110111 ns/iter 2.4873470862084837 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4861717173956195 ns/iter 2.487497865191268 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.486620188608647 ns/iter 2.4871968080426234 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.4200346278659914 ns/iter 3.4189465014347107 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.419070141059956 ns/iter 3.4175378116971133 ns/iter 1.00
Regex_Caret_X_Hyphen 12.560916061622386 ns/iter 12.527434995876682 ns/iter 1.00
Regex_Period_Md_Dollar 75.10367131748212 ns/iter 73.57518787834836 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 6.2174311463589405 ns/iter 7.1460825934591305 ns/iter 0.87
Regex_Caret_Period_Range_Dollar 3.7291643046850482 ns/iter 3.748331126870648 ns/iter 0.99
Regex_Nested_Backtrack 493.60976111112006 ns/iter 493.74734527764986 ns/iter 1.00
Pointer_Object_Traverse 44.88379550911929 ns/iter 44.77268042194476 ns/iter 1.00
Pointer_Object_Try_Traverse 52.30235738829302 ns/iter 52.346571993886705 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 351.9664473025449 ns/iter 352.87085163843483 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: c0e816c Previous: 16adce4 Ratio
JSON_Array_Of_Objects_Unique 359.22545917076803 ns/iter 330.43087146073617 ns/iter 1.09
JSON_Parse_1 23218.1766239622 ns/iter 21221.843152698468 ns/iter 1.09
JSON_Fast_Hash_Helm_Chart_Lock 55.2101444757832 ns/iter 47.69326086406976 ns/iter 1.16
JSON_Equality_Helm_Chart_Lock 144.55442444706986 ns/iter 133.06913206316509 ns/iter 1.09
Regex_Lower_S_Or_Upper_S_Asterisk 1.7994528081793713 ns/iter 1.5689222735977724 ns/iter 1.15
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7187657233845548 ns/iter 1.5720424518240115 ns/iter 1.09
Regex_Period_Asterisk 1.695111402955499 ns/iter 1.5849100255488364 ns/iter 1.07
Regex_Group_Period_Asterisk_Group 1.7865873465353803 ns/iter 1.619187085412587 ns/iter 1.10
Regex_Period_Plus 2.038139280308566 ns/iter 1.8939170674439665 ns/iter 1.08
Regex_Period 2.145592309242234 ns/iter 2.091953773469908 ns/iter 1.03
Regex_Caret_Period_Plus_Dollar 2.0144867082558395 ns/iter 1.976951513751499 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 2.017867943289679 ns/iter 2.015001725966835 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 1.6846806492354147 ns/iter 1.6003665135146479 ns/iter 1.05
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6896086135651152 ns/iter 1.5698904069141555 ns/iter 1.08
Regex_Caret_X_Hyphen 7.094592360899905 ns/iter 6.306310681506139 ns/iter 1.12
Regex_Period_Md_Dollar 75.21051192037237 ns/iter 67.78072380757295 ns/iter 1.11
Regex_Caret_Slash_Period_Asterisk 6.706915167176743 ns/iter 6.3807192263469545 ns/iter 1.05
Regex_Caret_Period_Range_Dollar 2.1691979114831272 ns/iter 2.046429970595506 ns/iter 1.06
Regex_Nested_Backtrack 773.6063207591119 ns/iter 726.0965320237835 ns/iter 1.07
Pointer_Object_Traverse 15.780735220619967 ns/iter 14.844123704205458 ns/iter 1.06
Pointer_Object_Try_Traverse 33.63618222078235 ns/iter 31.284784202430174 ns/iter 1.08
Pointer_Push_Back_Pointer_To_Weak_Pointer 182.8846244817988 ns/iter 172.65156969807174 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: c0e816c Previous: 16adce4 Ratio
JSON_Array_Of_Objects_Unique 417.44447370785304 ns/iter 416.14630386214554 ns/iter 1.00
JSON_Parse_1 80575.18973213971 ns/iter 79599.30360252195 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 55.43681999999989 ns/iter 54.34384999999793 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 217.88484374997805 ns/iter 219.54805269875777 ns/iter 0.99
Regex_Lower_S_Or_Upper_S_Asterisk 8.218773437500866 ns/iter 8.154109785026717 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.229986607143198 ns/iter 8.172507812501198 ns/iter 1.01
Regex_Period_Asterisk 7.923449964628303 ns/iter 7.840069196428497 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 7.7841629464283 ns/iter 7.934264696722221 ns/iter 0.98
Regex_Period_Plus 7.876587018408952 ns/iter 7.777581661707126 ns/iter 1.01
Regex_Period 7.88906916120931 ns/iter 7.850442822096568 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 8.401676339284997 ns/iter 7.767732142857246 ns/iter 1.08
Regex_Caret_Group_Period_Plus_Group_Dollar 8.201373177672297 ns/iter 8.743973214285614 ns/iter 0.94
Regex_Caret_Period_Asterisk_Dollar 7.762818080356837 ns/iter 7.933832107439376 ns/iter 0.98
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.802452197311538 ns/iter 8.064123178284392 ns/iter 0.97
Regex_Caret_X_Hyphen 11.511426785712533 ns/iter 11.977482142857607 ns/iter 0.96
Regex_Period_Md_Dollar 145.61845982142987 ns/iter 143.47674805907258 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 11.952119642858504 ns/iter 11.82410178571404 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 8.840003531963857 ns/iter 9.251618262268787 ns/iter 0.96
Regex_Nested_Backtrack 596.2962499999946 ns/iter 592.2207142856248 ns/iter 1.01
Pointer_Object_Traverse 55.834349999997805 ns/iter 55.9038800000053 ns/iter 1.00
Pointer_Object_Try_Traverse 77.07388392856579 ns/iter 75.9869531250068 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 178.95877490704726 ns/iter 191.80450819683765 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: c0e816c Previous: 16adce4 Ratio
Pointer_Object_Traverse 44.82138520649138 ns/iter 44.315735461146176 ns/iter 1.01
Pointer_Object_Try_Traverse 22.401357289527912 ns/iter 22.4184684058889 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.1961461223287 ns/iter 216.25236959070153 ns/iter 0.99
Regex_Lower_S_Or_Upper_S_Asterisk 3.1280167241618826 ns/iter 2.4868763559190525 ns/iter 1.26
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1273942701445625 ns/iter 2.4883152921491214 ns/iter 1.26
Regex_Period_Asterisk 3.1299801042398308 ns/iter 2.4896222895821816 ns/iter 1.26
Regex_Group_Period_Asterisk_Group 3.1311679426556993 ns/iter 2.495235746444008 ns/iter 1.25
Regex_Period_Plus 3.127439409360705 ns/iter 2.797069635064368 ns/iter 1.12
Regex_Period 3.1239431008004543 ns/iter 2.798695325674326 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 3.1219881663240563 ns/iter 2.796517724700727 ns/iter 1.12
Regex_Caret_Group_Period_Plus_Group_Dollar 3.124664483604206 ns/iter 2.8251081758681287 ns/iter 1.11
Regex_Caret_Period_Asterisk_Dollar 3.709321251131874 ns/iter 2.488767658546089 ns/iter 1.49
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.132992819952936 ns/iter 2.493301441550906 ns/iter 1.26
Regex_Caret_X_Hyphen 12.429496529178117 ns/iter 13.05201626475827 ns/iter 0.95
Regex_Period_Md_Dollar 92.53590275489708 ns/iter 93.39210618283377 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 6.217498137980038 ns/iter 6.216727963282871 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.037567628955742 ns/iter 4.043306672425007 ns/iter 1.00
Regex_Nested_Backtrack 814.0950065352251 ns/iter 819.5413688749217 ns/iter 0.99
JSON_Array_Of_Objects_Unique 381.73868989990297 ns/iter 401.9023872448747 ns/iter 0.95
JSON_Parse_1 32995.37358257878 ns/iter 32681.681430524735 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 68.68845869436795 ns/iter 58.04574385832107 ns/iter 1.18
JSON_Equality_Helm_Chart_Lock 143.20484678127565 ns/iter 143.1157399725114 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 55481f3 into main Jan 10, 2025
13 checks passed
@jviotti jviotti deleted the unidentify branch January 10, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant