-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix canonicalization of relative URI paths with leading slashes #1430
Conversation
3ed790f
to
1d2208c
Compare
Signed-off-by: Juan Cruz Viotti <[email protected]>
1d2208c
to
ea1ce7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: ea1ce7b | Previous: 55481f3 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
445.60516922473875 ns/iter |
443.41870124154434 ns/iter |
1.00 |
JSON_Parse_1 |
30474.08157451927 ns/iter |
30856.39630054861 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
54.696734495071766 ns/iter |
54.717853651566976 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
147.2647251015207 ns/iter |
150.29080986917077 ns/iter |
0.98 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.485063422748493 ns/iter |
2.1813326640329915 ns/iter |
1.14 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.2091511509394706 ns/iter |
2.1860155093271376 ns/iter |
1.01 |
Regex_Period_Asterisk |
2.4870832497096655 ns/iter |
2.181417065696179 ns/iter |
1.14 |
Regex_Group_Period_Asterisk_Group |
2.206944817857332 ns/iter |
2.182036349715757 ns/iter |
1.01 |
Regex_Period_Plus |
2.8023961747515123 ns/iter |
2.4914004008456194 ns/iter |
1.12 |
Regex_Period |
2.4888478278182733 ns/iter |
2.506632647577241 ns/iter |
0.99 |
Regex_Caret_Period_Plus_Dollar |
2.487077580713637 ns/iter |
2.4887776977850873 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.4898733459573013 ns/iter |
2.489922474578475 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.417757631527733 ns/iter |
3.4192200934329176 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.420922026643838 ns/iter |
3.418952737835449 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
13.046978400596892 ns/iter |
12.504706843113246 ns/iter |
1.04 |
Regex_Period_Md_Dollar |
76.37171410945513 ns/iter |
74.05161340026288 ns/iter |
1.03 |
Regex_Caret_Slash_Period_Asterisk |
7.144947229049061 ns/iter |
7.093413433351044 ns/iter |
1.01 |
Regex_Caret_Period_Range_Dollar |
3.7310788490642794 ns/iter |
2.5058175069195956 ns/iter |
1.49 |
Regex_Nested_Backtrack |
494.16119316165356 ns/iter |
506.3542772193359 ns/iter |
0.98 |
Pointer_Object_Traverse |
44.994606371229835 ns/iter |
44.90762013352479 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.28629619157712 ns/iter |
52.26983470377153 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.50357063643787 ns/iter |
352.297219581662 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: ea1ce7b | Previous: 55481f3 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
335.38418296028703 ns/iter |
407.459216519292 ns/iter |
0.82 |
JSON_Parse_1 |
21471.639957682455 ns/iter |
25862.212085917818 ns/iter |
0.83 |
JSON_Fast_Hash_Helm_Chart_Lock |
50.609574999998586 ns/iter |
57.95479504845729 ns/iter |
0.87 |
JSON_Equality_Helm_Chart_Lock |
148.62096324134225 ns/iter |
154.35157276779012 ns/iter |
0.96 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.7745387625884925 ns/iter |
1.7515113674257687 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.752517447990792 ns/iter |
1.7316679848811976 ns/iter |
1.01 |
Regex_Period_Asterisk |
1.7253660358992646 ns/iter |
1.8475199273979472 ns/iter |
0.93 |
Regex_Group_Period_Asterisk_Group |
1.7366183688822856 ns/iter |
1.6977302224322826 ns/iter |
1.02 |
Regex_Period_Plus |
2.1724486171687114 ns/iter |
2.4910686245373266 ns/iter |
0.87 |
Regex_Period |
2.125345310454638 ns/iter |
2.165795449841771 ns/iter |
0.98 |
Regex_Caret_Period_Plus_Dollar |
2.4329042752240984 ns/iter |
2.0989762475510423 ns/iter |
1.16 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.082777136787431 ns/iter |
2.071488316107489 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
1.7160130147640287 ns/iter |
1.7085505559815002 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.7754251111953379 ns/iter |
1.6682543585173972 ns/iter |
1.06 |
Regex_Caret_X_Hyphen |
6.8460785024475 ns/iter |
6.564934534701128 ns/iter |
1.04 |
Regex_Period_Md_Dollar |
80.73072164594657 ns/iter |
71.20947022637732 ns/iter |
1.13 |
Regex_Caret_Slash_Period_Asterisk |
7.66361746419076 ns/iter |
7.5654015303254845 ns/iter |
1.01 |
Regex_Caret_Period_Range_Dollar |
2.307586821636042 ns/iter |
2.142386520023517 ns/iter |
1.08 |
Regex_Nested_Backtrack |
821.70641799164 ns/iter |
773.3462000510282 ns/iter |
1.06 |
Pointer_Object_Traverse |
16.42799842816522 ns/iter |
15.725582600629465 ns/iter |
1.04 |
Pointer_Object_Try_Traverse |
37.55729168750548 ns/iter |
35.45585758590162 ns/iter |
1.06 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
205.82916747408726 ns/iter |
181.87580669859832 ns/iter |
1.13 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: ea1ce7b | Previous: 55481f3 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
418.5141078035674 ns/iter |
419.10147843102794 ns/iter |
1.00 |
JSON_Parse_1 |
79751.69642857288 ns/iter |
81309.16294643495 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.12899000000016 ns/iter |
56.79349107143342 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
218.48898801386665 ns/iter |
214.83100000001087 ns/iter |
1.02 |
Regex_Lower_S_Or_Upper_S_Asterisk |
8.096039696000231 ns/iter |
8.09690219599542 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.777246840279372 ns/iter |
7.924672732480097 ns/iter |
0.98 |
Regex_Period_Asterisk |
8.035840142698348 ns/iter |
7.952081473214482 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
7.843454429270604 ns/iter |
7.992249999999907 ns/iter |
0.98 |
Regex_Period_Plus |
8.28441826658757 ns/iter |
7.929559786028484 ns/iter |
1.04 |
Regex_Period |
7.97325800011933 ns/iter |
8.11947433035698 ns/iter |
0.98 |
Regex_Caret_Period_Plus_Dollar |
7.8588414827730135 ns/iter |
8.000271205356972 ns/iter |
0.98 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.171957106375013 ns/iter |
8.38834549826642 ns/iter |
0.97 |
Regex_Caret_Period_Asterisk_Dollar |
8.084136160714397 ns/iter |
8.303265625000073 ns/iter |
0.97 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.866075892856626 ns/iter |
8.224844159711257 ns/iter |
0.96 |
Regex_Caret_X_Hyphen |
11.537166071428423 ns/iter |
11.618403571428562 ns/iter |
0.99 |
Regex_Period_Md_Dollar |
141.6647146578244 ns/iter |
145.94708723451558 ns/iter |
0.97 |
Regex_Caret_Slash_Period_Asterisk |
11.675145483593411 ns/iter |
11.775487499999063 ns/iter |
0.99 |
Regex_Caret_Period_Range_Dollar |
9.071930803571858 ns/iter |
9.086469602291999 ns/iter |
1.00 |
Regex_Nested_Backtrack |
590.4242000000295 ns/iter |
588.6363392856911 ns/iter |
1.00 |
Pointer_Object_Traverse |
56.17273000000296 ns/iter |
56.69698214285899 ns/iter |
0.99 |
Pointer_Object_Try_Traverse |
75.89804687500035 ns/iter |
76.37816964285449 ns/iter |
0.99 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
175.02017634109637 ns/iter |
175.17648494484808 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: ea1ce7b | Previous: 55481f3 | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
42.312840953666814 ns/iter |
44.323071200537065 ns/iter |
0.95 |
Pointer_Object_Try_Traverse |
21.956429783631577 ns/iter |
22.409523536155056 ns/iter |
0.98 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
205.51002531026546 ns/iter |
213.00843352003835 ns/iter |
0.96 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.380715515976842 ns/iter |
3.1354589423323262 ns/iter |
0.76 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.3572371777507226 ns/iter |
3.1236844399220987 ns/iter |
0.75 |
Regex_Period_Asterisk |
2.345495968145103 ns/iter |
3.1244189730837797 ns/iter |
0.75 |
Regex_Group_Period_Asterisk_Group |
2.3429095663146278 ns/iter |
3.124149829439447 ns/iter |
0.75 |
Regex_Period_Plus |
2.6132386070950147 ns/iter |
3.1251358316953213 ns/iter |
0.84 |
Regex_Period |
2.61821253918162 ns/iter |
3.1283836481291374 ns/iter |
0.84 |
Regex_Caret_Period_Plus_Dollar |
2.64187837301944 ns/iter |
3.1256782396702962 ns/iter |
0.85 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.605846396319559 ns/iter |
3.1257985513587023 ns/iter |
0.83 |
Regex_Caret_Period_Asterisk_Dollar |
3.4865905512407975 ns/iter |
3.126567055852649 ns/iter |
1.12 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.4836501011983345 ns/iter |
3.1302327364697122 ns/iter |
1.11 |
Regex_Caret_X_Hyphen |
11.55992921672495 ns/iter |
12.43179876404824 ns/iter |
0.93 |
Regex_Period_Md_Dollar |
83.11354014242977 ns/iter |
89.63427958149308 ns/iter |
0.93 |
Regex_Caret_Slash_Period_Asterisk |
6.644037305914386 ns/iter |
7.1531579424733405 ns/iter |
0.93 |
Regex_Caret_Period_Range_Dollar |
3.805208364707941 ns/iter |
3.185703537765074 ns/iter |
1.19 |
Regex_Nested_Backtrack |
781.7919056625694 ns/iter |
813.1069888583747 ns/iter |
0.96 |
JSON_Array_Of_Objects_Unique |
368.4044019068864 ns/iter |
377.73481002123015 ns/iter |
0.98 |
JSON_Parse_1 |
30507.856482922685 ns/iter |
32810.163484040466 ns/iter |
0.93 |
JSON_Fast_Hash_Helm_Chart_Lock |
59.14036026954535 ns/iter |
63.95427803930726 ns/iter |
0.92 |
JSON_Equality_Helm_Chart_Lock |
133.92885082669335 ns/iter |
142.6291877626806 ns/iter |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]