Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish a simple YAML integration #1436

Closed
wants to merge 1 commit into from
Closed

Finish a simple YAML integration #1436

wants to merge 1 commit into from

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 14, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti force-pushed the libyaml branch 3 times, most recently from 5348cc1 to c1450fd Compare January 14, 2025 18:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: d65bb29 Previous: b931c8d Ratio
JSON_Array_Of_Objects_Unique 350.81637757463375 ns/iter 330.39450489214516 ns/iter 1.06
JSON_Parse_1 23031.649765656744 ns/iter 21225.648270405964 ns/iter 1.09
JSON_Fast_Hash_Helm_Chart_Lock 52.137319400282074 ns/iter 47.75058310549035 ns/iter 1.09
JSON_Equality_Helm_Chart_Lock 139.10378201517537 ns/iter 130.26022253066216 ns/iter 1.07
Regex_Lower_S_Or_Upper_S_Asterisk 1.6910321476921606 ns/iter 1.5719360308193295 ns/iter 1.08
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7234863005041126 ns/iter 1.576376971647649 ns/iter 1.09
Regex_Period_Asterisk 1.7389018626680226 ns/iter 1.5902572612277817 ns/iter 1.09
Regex_Group_Period_Asterisk_Group 2.0770316434654372 ns/iter 1.5690219709601247 ns/iter 1.32
Regex_Period_Plus 2.0338826060873103 ns/iter 1.8837776078296258 ns/iter 1.08
Regex_Period 2.07424683085825 ns/iter 1.9214252722334755 ns/iter 1.08
Regex_Caret_Period_Plus_Dollar 2.458049163131533 ns/iter 1.8779039705970533 ns/iter 1.31
Regex_Caret_Group_Period_Plus_Group_Dollar 2.030694055328062 ns/iter 1.8817743507867872 ns/iter 1.08
Regex_Caret_Period_Asterisk_Dollar 1.6823705169278915 ns/iter 1.570907044275521 ns/iter 1.07
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6866874939059662 ns/iter 1.5682028223468762 ns/iter 1.08
Regex_Caret_X_Hyphen 6.733970575337029 ns/iter 6.28076144285671 ns/iter 1.07
Regex_Period_Md_Dollar 72.64313845793937 ns/iter 67.76550377141864 ns/iter 1.07
Regex_Caret_Slash_Period_Asterisk 6.32611883081195 ns/iter 5.948141691966838 ns/iter 1.06
Regex_Caret_Period_Range_Dollar 2.2672035529677506 ns/iter 2.051332622590835 ns/iter 1.11
Regex_Nested_Backtrack 783.9804942059568 ns/iter 728.1091689554235 ns/iter 1.08
Pointer_Object_Traverse 16.09106027933527 ns/iter 14.937242716690811 ns/iter 1.08
Pointer_Object_Try_Traverse 33.79062452901788 ns/iter 32.34675179005145 ns/iter 1.04
Pointer_Push_Back_Pointer_To_Weak_Pointer 183.4476740394606 ns/iter 173.98998474878596 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: d65bb29 Previous: b931c8d Ratio
JSON_Array_Of_Objects_Unique 411.33202343046185 ns/iter 395.3326130777526 ns/iter 1.04
JSON_Parse_1 30082.448235800384 ns/iter 29712.852101557663 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 58.82064317678542 ns/iter 58.75005603374625 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 145.9169548279099 ns/iter 154.84995869075541 ns/iter 0.94
Regex_Lower_S_Or_Upper_S_Asterisk 2.2078014204856995 ns/iter 2.200192911716812 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.203470595492146 ns/iter 2.2065809327165464 ns/iter 1.00
Regex_Period_Asterisk 2.2152705060843783 ns/iter 2.2054954932448654 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.224439118976909 ns/iter 2.19495538323948 ns/iter 1.01
Regex_Period_Plus 2.7967469954787934 ns/iter 2.4917602377993515 ns/iter 1.12
Regex_Period 2.796503827405594 ns/iter 2.4924219323804877 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 2.7966886659428445 ns/iter 2.510090743743099 ns/iter 1.11
Regex_Caret_Group_Period_Plus_Group_Dollar 2.805205357140847 ns/iter 2.4905522864761673 ns/iter 1.13
Regex_Caret_Period_Asterisk_Dollar 3.4368079340293867 ns/iter 2.487562624532631 ns/iter 1.38
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4197534330199035 ns/iter 2.2739165268179877 ns/iter 1.50
Regex_Caret_X_Hyphen 13.060524110894635 ns/iter 12.635164005000437 ns/iter 1.03
Regex_Period_Md_Dollar 73.53297129232365 ns/iter 73.83276672803362 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 5.5973003271211885 ns/iter 5.288012498631642 ns/iter 1.06
Regex_Caret_Period_Range_Dollar 4.0425477321572005 ns/iter 2.8019644558841037 ns/iter 1.44
Regex_Nested_Backtrack 491.0672551614121 ns/iter 523.5228814845726 ns/iter 0.94
Pointer_Object_Traverse 44.23926981368287 ns/iter 44.38325430302533 ns/iter 1.00
Pointer_Object_Try_Traverse 52.675761950194556 ns/iter 52.603682109720324 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.23775591797187 ns/iter 352.0926318520147 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: d65bb29 Previous: b931c8d Ratio
Pointer_Object_Traverse 43.76586011152679 ns/iter 43.89193467863378 ns/iter 1.00
Pointer_Object_Try_Traverse 22.43129199752763 ns/iter 22.41308677902005 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.28111860980974 ns/iter 213.32790091502352 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4888636123233736 ns/iter 2.4853797668696656 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.494959062193897 ns/iter 2.486211305191703 ns/iter 1.00
Regex_Period_Asterisk 2.493100290569216 ns/iter 2.4855860606544358 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.4926280836344428 ns/iter 2.486036306992502 ns/iter 1.00
Regex_Period_Plus 2.7996658383804425 ns/iter 2.7964063493281106 ns/iter 1.00
Regex_Period 2.80111393316158 ns/iter 2.7962303043252517 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.799004357120383 ns/iter 2.796387858626626 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.8064602256650453 ns/iter 2.7986555044636146 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.7499049775270548 ns/iter 3.728111050847092 ns/iter 1.01
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.729619120829059 ns/iter 3.7319589472283856 ns/iter 1.00
Regex_Caret_X_Hyphen 13.052953467511767 ns/iter 12.428428056766613 ns/iter 1.05
Regex_Period_Md_Dollar 88.1650690441803 ns/iter 87.5522356251301 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 6.231561748967575 ns/iter 7.147485808338387 ns/iter 0.87
Regex_Caret_Period_Range_Dollar 4.055047064757285 ns/iter 4.047397060560597 ns/iter 1.00
Regex_Nested_Backtrack 838.3669267943716 ns/iter 828.6089675820134 ns/iter 1.01
JSON_Array_Of_Objects_Unique 377.42935203427527 ns/iter 382.0400072587413 ns/iter 0.99
JSON_Parse_1 32849.628881476754 ns/iter 33032.28055999497 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 62.487987202260314 ns/iter 62.45494284314482 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 142.29301780074533 ns/iter 142.45138139650422 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: d65bb29 Previous: b931c8d Ratio
JSON_Array_Of_Objects_Unique 417.058940165423 ns/iter 417.62277599902325 ns/iter 1.00
JSON_Parse_1 80211.14955357891 ns/iter 81163.19196430157 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 56.162883928568675 ns/iter 53.56711000001724 ns/iter 1.05
JSON_Equality_Helm_Chart_Lock 221.45749999999964 ns/iter 212.30368749996842 ns/iter 1.04
Regex_Lower_S_Or_Upper_S_Asterisk 8.121407106600715 ns/iter 8.11904594589669 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.811463169643065 ns/iter 7.8235111257902945 ns/iter 1.00
Regex_Period_Asterisk 7.864672991072044 ns/iter 7.920648178926899 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 8.067724330357454 ns/iter 8.20333816964336 ns/iter 0.98
Regex_Period_Plus 8.194174516990813 ns/iter 7.892888392857193 ns/iter 1.04
Regex_Period 7.758246651785276 ns/iter 8.095877642430391 ns/iter 0.96
Regex_Caret_Period_Plus_Dollar 7.8649776785714005 ns/iter 8.086762463898003 ns/iter 0.97
Regex_Caret_Group_Period_Plus_Group_Dollar 8.1242959458737 ns/iter 8.159023624287682 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 8.021102642763587 ns/iter 7.907882812498356 ns/iter 1.01
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.839415178571483 ns/iter 7.9381975446425805 ns/iter 0.99
Regex_Caret_X_Hyphen 11.78096093750014 ns/iter 11.672144642858484 ns/iter 1.01
Regex_Period_Md_Dollar 162.41279017858037 ns/iter 141.3607637785502 ns/iter 1.15
Regex_Caret_Slash_Period_Asterisk 11.968903571426738 ns/iter 11.951282142855948 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 9.322576297667418 ns/iter 8.716593749998225 ns/iter 1.07
Regex_Nested_Backtrack 611.1770535714609 ns/iter 595.6651785713315 ns/iter 1.03
Pointer_Object_Traverse 56.04082142857538 ns/iter 55.88107000000945 ns/iter 1.00
Pointer_Object_Try_Traverse 75.986551339291 ns/iter 76.01954241072762 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 183.43442709236191 ns/iter 188.54562397725462 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the libyaml branch 7 times, most recently from 6f19a02 to 7e50557 Compare January 14, 2025 21:00
@jviotti jviotti changed the title [WIP] Implement a YAML interoperability module using libyaml Add basic YAML parsing tests Jan 14, 2025
@jviotti jviotti marked this pull request as ready for review January 14, 2025 21:00
@jviotti jviotti force-pushed the libyaml branch 3 times, most recently from 76adeef to 3b148a7 Compare January 14, 2025 21:49
Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti jviotti changed the title Add basic YAML parsing tests Finish a simple YAML integration Jan 15, 2025
@jviotti jviotti closed this Jan 15, 2025
@jviotti jviotti deleted the libyaml branch January 15, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant