Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how FlatFileSchemaResolver abstracts reading files #1449

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 15, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: a65ff3f Previous: 5ad87d0 Ratio
JSON_Array_Of_Objects_Unique 402.81887448069125 ns/iter 410.54483214524436 ns/iter 0.98
JSON_Parse_1 30346.48530176913 ns/iter 29958.079739346053 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 58.75599117866041 ns/iter 58.79223558936988 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 153.60745195729973 ns/iter 157.28012902631625 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 2.189761259920909 ns/iter 2.217767326602471 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.194471173170273 ns/iter 2.1967026971884556 ns/iter 1.00
Regex_Period_Asterisk 2.199550938295447 ns/iter 2.204751738229215 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.2267285210493912 ns/iter 2.1965836265836503 ns/iter 1.01
Regex_Period_Plus 2.79797517077087 ns/iter 2.799238484361064 ns/iter 1.00
Regex_Period 2.79676274466073 ns/iter 2.800540364044735 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4956032127526395 ns/iter 3.111302194366156 ns/iter 0.80
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4864598108911924 ns/iter 2.8030626485047705 ns/iter 0.89
Regex_Caret_Period_Asterisk_Dollar 2.373601880658523 ns/iter 3.729388050457561 ns/iter 0.64
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.2079441578919066 ns/iter 3.420058407273413 ns/iter 0.65
Regex_Caret_X_Hyphen 13.055313830437893 ns/iter 5.9125502876363765 ns/iter 2.21
Regex_Period_Md_Dollar 74.7226308905395 ns/iter 74.3458374239799 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 5.283905934159675 ns/iter 5.90437098183625 ns/iter 0.89
Regex_Caret_Period_Range_Dollar 2.798166586378943 ns/iter 4.0470490847903635 ns/iter 0.69
Regex_Nested_Backtrack 502.1000928752084 ns/iter 493.64337453297094 ns/iter 1.02
Pointer_Object_Traverse 45.0034849105984 ns/iter 44.453243191983084 ns/iter 1.01
Pointer_Object_Try_Traverse 52.589009569731466 ns/iter 52.623495328853195 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 351.7485839126518 ns/iter 352.15686777698505 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: a65ff3f Previous: 5ad87d0 Ratio
JSON_Array_Of_Objects_Unique 365.9404693514786 ns/iter 356.46607707298415 ns/iter 1.03
JSON_Parse_1 23941.578821682968 ns/iter 23052.775474843776 ns/iter 1.04
JSON_Fast_Hash_Helm_Chart_Lock 51.906485641046444 ns/iter 50.50762079999913 ns/iter 1.03
JSON_Equality_Helm_Chart_Lock 139.58732017731046 ns/iter 133.3890160905965 ns/iter 1.05
Regex_Lower_S_Or_Upper_S_Asterisk 1.6011259755546456 ns/iter 1.662667632659455 ns/iter 0.96
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.6736552245469554 ns/iter 1.6377944533275341 ns/iter 1.02
Regex_Period_Asterisk 1.7151936561498942 ns/iter 1.6761359419013826 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 1.7082851193227437 ns/iter 1.676743950269039 ns/iter 1.02
Regex_Period_Plus 2.0736032585041104 ns/iter 1.9486592363022772 ns/iter 1.06
Regex_Period 2.0565739321972445 ns/iter 1.9424460531634398 ns/iter 1.06
Regex_Caret_Period_Plus_Dollar 2.247692612035009 ns/iter 1.9600497779990533 ns/iter 1.15
Regex_Caret_Group_Period_Plus_Group_Dollar 2.284396270932718 ns/iter 1.964951222363723 ns/iter 1.16
Regex_Caret_Period_Asterisk_Dollar 1.640418919375534 ns/iter 1.681262961289108 ns/iter 0.98
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6966679458204075 ns/iter 1.6368369973341155 ns/iter 1.04
Regex_Caret_X_Hyphen 6.875843849696344 ns/iter 6.514885297609774 ns/iter 1.06
Regex_Period_Md_Dollar 68.55443338580993 ns/iter 68.45052344181082 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 6.667177601542108 ns/iter 6.093566669999291 ns/iter 1.09
Regex_Caret_Period_Range_Dollar 2.237975572041907 ns/iter 2.05771040841992 ns/iter 1.09
Regex_Nested_Backtrack 806.6441043617109 ns/iter 736.6455644171909 ns/iter 1.10
Pointer_Object_Traverse 15.972971699802581 ns/iter 14.77760901714935 ns/iter 1.08
Pointer_Object_Try_Traverse 34.015633655267955 ns/iter 31.48727281582701 ns/iter 1.08
Pointer_Push_Back_Pointer_To_Weak_Pointer 183.20983199276273 ns/iter 178.94127940367434 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: a65ff3f Previous: 5ad87d0 Ratio
JSON_Array_Of_Objects_Unique 425.7564973280566 ns/iter 417.23353617487845 ns/iter 1.02
JSON_Parse_1 80340.70312499253 ns/iter 79684.83258928214 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 55.326535714286244 ns/iter 57.98177000000351 ns/iter 0.95
JSON_Equality_Helm_Chart_Lock 222.25409375000282 ns/iter 221.36824999996918 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 8.141978535080137 ns/iter 8.092111571016876 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.379334821428941 ns/iter 8.056637910460836 ns/iter 1.04
Regex_Period_Asterisk 7.809444607993246 ns/iter 8.716828086086014 ns/iter 0.90
Regex_Group_Period_Asterisk_Group 7.8299017857145055 ns/iter 7.816297732961946 ns/iter 1.00
Regex_Period_Plus 7.976005580356826 ns/iter 7.942253535972656 ns/iter 1.00
Regex_Period 8.09189397321473 ns/iter 8.770604425130022 ns/iter 0.92
Regex_Caret_Period_Plus_Dollar 8.036615589123478 ns/iter 7.844628348214755 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 8.191135677718266 ns/iter 8.24185714285695 ns/iter 0.99
Regex_Caret_Period_Asterisk_Dollar 8.2219419275797 ns/iter 7.956792410714896 ns/iter 1.03
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.907671874999776 ns/iter 8.154429874310651 ns/iter 0.97
Regex_Caret_X_Hyphen 12.143166071429132 ns/iter 11.533114285715637 ns/iter 1.05
Regex_Period_Md_Dollar 141.84387089982167 ns/iter 144.5246453337328 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 11.598625000000798 ns/iter 11.69555937499922 ns/iter 0.99
Regex_Caret_Period_Range_Dollar 9.612921875000069 ns/iter 8.816606249999026 ns/iter 1.09
Regex_Nested_Backtrack 600.5373000000418 ns/iter 591.9220535714333 ns/iter 1.01
Pointer_Object_Traverse 56.516714285714485 ns/iter 56.688491071434605 ns/iter 1.00
Pointer_Object_Try_Traverse 77.170792410719 ns/iter 76.3351562499943 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 189.7113383670917 ns/iter 179.7423937327417 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: a65ff3f Previous: 5ad87d0 Ratio
Pointer_Object_Traverse 43.86433106765683 ns/iter 43.963897528773806 ns/iter 1.00
Pointer_Object_Try_Traverse 22.44476586880487 ns/iter 22.4004824352545 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.26666930513088 ns/iter 213.18271278019577 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4879099367098556 ns/iter 3.1223928973167974 ns/iter 0.80
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4864032288009676 ns/iter 3.1259921115358895 ns/iter 0.80
Regex_Period_Asterisk 2.489189819021351 ns/iter 3.1229270505378195 ns/iter 0.80
Regex_Group_Period_Asterisk_Group 2.4920450477879026 ns/iter 3.1328414992341087 ns/iter 0.80
Regex_Period_Plus 2.8037137406746213 ns/iter 3.1232910154560267 ns/iter 0.90
Regex_Period 2.8046094621488247 ns/iter 3.1969665383737396 ns/iter 0.88
Regex_Caret_Period_Plus_Dollar 2.800286440184709 ns/iter 3.1193341696640227 ns/iter 0.90
Regex_Caret_Group_Period_Plus_Group_Dollar 2.7971491030179827 ns/iter 3.1211959806448077 ns/iter 0.90
Regex_Caret_Period_Asterisk_Dollar 3.7298317756532193 ns/iter 3.730395790364378 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.730369777244658 ns/iter 3.7274218094576885 ns/iter 1.00
Regex_Caret_X_Hyphen 13.05195579305385 ns/iter 12.431804050715199 ns/iter 1.05
Regex_Period_Md_Dollar 113.34434296092441 ns/iter 89.99540607552115 ns/iter 1.26
Regex_Caret_Slash_Period_Asterisk 7.155236148454573 ns/iter 6.215885044813196 ns/iter 1.15
Regex_Caret_Period_Range_Dollar 4.04577433838412 ns/iter 4.041815486852489 ns/iter 1.00
Regex_Nested_Backtrack 881.3185713549032 ns/iter 821.0625783296108 ns/iter 1.07
JSON_Array_Of_Objects_Unique 377.45972971664094 ns/iter 385.2388574611975 ns/iter 0.98
JSON_Parse_1 32620.25332214215 ns/iter 32700.798716210076 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 65.58885096323084 ns/iter 63.57763164779136 ns/iter 1.03
JSON_Equality_Helm_Chart_Lock 143.17410166258216 ns/iter 142.76791559343624 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit d184391 into main Jan 15, 2025
13 checks passed
@jviotti jviotti deleted the flat-file-reader branch January 15, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant