Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume FlatMap from Noa #1455

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Consume FlatMap from Noa #1455

merged 1 commit into from
Jan 20, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 20, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Signed-off-by: Juan Cruz Viotti <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 34a37fc Previous: e69aabf Ratio
JSON_Array_Of_Objects_Unique 338.3902558112431 ns/iter 352.64490935294776 ns/iter 0.96
JSON_Parse_1 21909.281284398 ns/iter 23513.081980283958 ns/iter 0.93
JSON_Fast_Hash_Helm_Chart_Lock 46.296935078496865 ns/iter 50.510620800002926 ns/iter 0.92
JSON_Equality_Helm_Chart_Lock 132.7458525400763 ns/iter 138.0710931476307 ns/iter 0.96
Regex_Lower_S_Or_Upper_S_Asterisk 1.3588172092604696 ns/iter 1.408677810355686 ns/iter 0.96
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.3702048228762362 ns/iter 1.4102656686447574 ns/iter 0.97
Regex_Period_Asterisk 1.3587265395110677 ns/iter 1.4387311945127639 ns/iter 0.94
Regex_Group_Period_Asterisk_Group 1.3556155401423207 ns/iter 1.4581239219130147 ns/iter 0.93
Regex_Period_Plus 1.6399263810565619 ns/iter 1.7134263915684405 ns/iter 0.96
Regex_Period 1.639441015945517 ns/iter 1.6936765129868705 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 1.657016964937784 ns/iter 1.6899253413145094 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 1.6564108353680767 ns/iter 1.7275097202385834 ns/iter 0.96
Regex_Caret_Period_Asterisk_Dollar 1.4012957294881743 ns/iter 1.4309314736758785 ns/iter 0.98
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.392103421593296 ns/iter 1.413937529133086 ns/iter 0.98
Regex_Caret_X_Hyphen 6.13083880429768 ns/iter 6.3374328222048435 ns/iter 0.97
Regex_Period_Md_Dollar 72.0977693636844 ns/iter 74.64685880547636 ns/iter 0.97
Regex_Caret_Slash_Period_Asterisk 6.76572108470056 ns/iter 6.93260027874596 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 1.790060433507395 ns/iter 1.852601770363592 ns/iter 0.97
Regex_Nested_Backtrack 713.1800615276487 ns/iter 751.5838324533657 ns/iter 0.95
Pointer_Object_Traverse 27.757274411783076 ns/iter 28.90659918138547 ns/iter 0.96
Pointer_Object_Try_Traverse 43.22391566462822 ns/iter 43.25785592776318 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 176.25725567436575 ns/iter 185.5259342149773 ns/iter 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 34a37fc Previous: e69aabf Ratio
JSON_Array_Of_Objects_Unique 411.38369943195835 ns/iter 401.50121477081086 ns/iter 1.02
JSON_Parse_1 30069.525819777566 ns/iter 30526.754071236286 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 58.77877256174921 ns/iter 58.79230113769065 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 141.9664854240199 ns/iter 147.61262061778908 ns/iter 0.96
Regex_Lower_S_Or_Upper_S_Asterisk 2.2030297654576043 ns/iter 2.1934566604628807 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.2060623898706373 ns/iter 2.2103959665690516 ns/iter 1.00
Regex_Period_Asterisk 2.205240331374482 ns/iter 2.1910967652032634 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 2.203210400814336 ns/iter 2.210173275903394 ns/iter 1.00
Regex_Period_Plus 2.4878243301501977 ns/iter 2.493106066013462 ns/iter 1.00
Regex_Period 2.48969422671934 ns/iter 2.490218727542163 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.490053764487293 ns/iter 2.7975946422386726 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 2.488756077721506 ns/iter 2.4881549228993527 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 2.4865386932277525 ns/iter 2.796477226722202 ns/iter 0.89
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.486135744306595 ns/iter 2.486665397015071 ns/iter 1.00
Regex_Caret_X_Hyphen 12.597332721107227 ns/iter 13.05277981810982 ns/iter 0.97
Regex_Period_Md_Dollar 75.67087795487515 ns/iter 73.4767624111389 ns/iter 1.03
Regex_Caret_Slash_Period_Asterisk 6.531265971330844 ns/iter 6.837693366677535 ns/iter 0.96
Regex_Caret_Period_Range_Dollar 3.8381536270384635 ns/iter 2.8006820165032913 ns/iter 1.37
Regex_Nested_Backtrack 494.20574966554364 ns/iter 493.3914345775061 ns/iter 1.00
Pointer_Object_Traverse 44.21231179082957 ns/iter 44.68078674177773 ns/iter 0.99
Pointer_Object_Try_Traverse 52.57318153212351 ns/iter 52.63679256889991 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 381.13315761654155 ns/iter 352.10125029040506 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 34a37fc Previous: e69aabf Ratio
JSON_Array_Of_Objects_Unique 311.8425259153286 ns/iter 291.8236876807318 ns/iter 1.07
JSON_Parse_1 33003.142816674816 ns/iter 32958.02189884738 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 27.467585122472787 ns/iter 39.26412349277548 ns/iter 0.70
JSON_Equality_Helm_Chart_Lock 158.81221472858937 ns/iter 146.26429739110623 ns/iter 1.09
Regex_Lower_S_Or_Upper_S_Asterisk 3.7307210271066387 ns/iter 3.1104460576704422 ns/iter 1.20
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.7327599880102107 ns/iter 3.1110425325112314 ns/iter 1.20
Regex_Period_Asterisk 3.7333713598400355 ns/iter 3.1097993491938807 ns/iter 1.20
Regex_Group_Period_Asterisk_Group 3.7311915558533073 ns/iter 3.109898426148064 ns/iter 1.20
Regex_Period_Plus 3.7364211336831454 ns/iter 3.4203648488334837 ns/iter 1.09
Regex_Period 3.7452921348063097 ns/iter 3.4514757927168143 ns/iter 1.09
Regex_Caret_Period_Plus_Dollar 3.728890692059037 ns/iter 3.424250663747123 ns/iter 1.09
Regex_Caret_Group_Period_Plus_Group_Dollar 3.730200954917286 ns/iter 3.4264799580744016 ns/iter 1.09
Regex_Caret_Period_Asterisk_Dollar 4.351140245774928 ns/iter 3.111501847307677 ns/iter 1.40
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.8262558326327163 ns/iter 3.1490665779820413 ns/iter 1.22
Regex_Caret_X_Hyphen 12.431018891764959 ns/iter 13.056370601629519 ns/iter 0.95
Regex_Period_Md_Dollar 103.22393649891144 ns/iter 103.26925081641824 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.14877533626111 ns/iter 7.371529925002344 ns/iter 0.97
Regex_Caret_Period_Range_Dollar 4.3525826614148375 ns/iter 4.353549148797111 ns/iter 1.00
Regex_Nested_Backtrack 818.7506931413212 ns/iter 835.7299369365663 ns/iter 0.98
Pointer_Object_Traverse 71.29943282193099 ns/iter 70.75435564415729 ns/iter 1.01
Pointer_Object_Try_Traverse 56.82356466623028 ns/iter 59.92411733996123 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 214.087018981748 ns/iter 215.31050784343344 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 34a37fc Previous: e69aabf Ratio
JSON_Array_Of_Objects_Unique 420.0140544665281 ns/iter 417.0288665000651 ns/iter 1.01
JSON_Parse_1 81753.07352351137 ns/iter 80392.32142856687 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 57.32648214285112 ns/iter 54.408928571427445 ns/iter 1.05
JSON_Equality_Helm_Chart_Lock 216.81181398158964 ns/iter 220.1651754390539 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 8.401283482142624 ns/iter 8.139428535092174 ns/iter 1.03
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.071041928254612 ns/iter 7.915883000375681 ns/iter 1.02
Regex_Period_Asterisk 7.919396205357135 ns/iter 7.782716517857732 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 7.8885039826396985 ns/iter 7.769059786745216 ns/iter 1.02
Regex_Period_Plus 7.979138392857671 ns/iter 7.791642822358613 ns/iter 1.02
Regex_Period 7.828953982906987 ns/iter 7.87533928571449 ns/iter 0.99
Regex_Caret_Period_Plus_Dollar 8.406343749999426 ns/iter 7.95252232142829 ns/iter 1.06
Regex_Caret_Group_Period_Plus_Group_Dollar 8.088765625000605 ns/iter 8.508903979871052 ns/iter 0.95
Regex_Caret_Period_Asterisk_Dollar 8.056343267604229 ns/iter 7.912553571428457 ns/iter 1.02
Regex_Caret_Group_Period_Asterisk_Group_Dollar 8.074555803571874 ns/iter 7.806922991070918 ns/iter 1.03
Regex_Caret_X_Hyphen 12.290985714287217 ns/iter 11.62646406250012 ns/iter 1.06
Regex_Period_Md_Dollar 142.93749138670682 ns/iter 151.65332589285794 ns/iter 0.94
Regex_Caret_Slash_Period_Asterisk 11.679715625000142 ns/iter 11.535187499999568 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 9.105558441493175 ns/iter 8.93635937499937 ns/iter 1.02
Regex_Nested_Backtrack 591.6168750000037 ns/iter 597.7024999999969 ns/iter 0.99
Pointer_Object_Traverse 55.98707999999988 ns/iter 55.94758035714773 ns/iter 1.00
Pointer_Object_Try_Traverse 75.79749999999663 ns/iter 75.84002232143204 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 181.92223945734136 ns/iter 188.0416507180104 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 110f9e6 into main Jan 20, 2025
13 checks passed
@jviotti jviotti deleted the noa-flat-map branch January 20, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant