feat: allow links in markdown hovers

[Hellebore]

Checklist

• If package.json or yarn.lock have changed, then test the VSIX built by yarn run vsce package works from a direct install

Summary by Sourcery

New Features:

• Allow links in Markdown hovers.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request enables the use of links in markdown hovers by setting the isTrusted property to true in the markdown client options.

Class diagram showing updated LanguageClientOptions configuration

classDiagram
    class LanguageClientOptions {
        +markdown: MarkdownOptions
        +diagnosticCollectionName: string
        +documentSelector: DocumentSelector[]
    }
    class MarkdownOptions {
        +isTrusted: boolean
    }
    LanguageClientOptions *-- MarkdownOptions
    note for LanguageClientOptions "Updated to include markdown options"
    note for MarkdownOptions "New configuration to enable trusted links"

Loading

File-Level Changes

Change	Details	Files
Enable links in markdown hovers.	Set isTrusted to true in the markdown client options.	src/extension.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Hellebore - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• [FILTERED by comment_validation]
  Setting markdown.isTrusted to true could expose the system to security vulnerabilities. (link)

Overall Comments:

• Please document the security considerations of enabling trusted markdown. Confirm that markdown content from the language server is properly sanitized to prevent XSS risks.

Here's what I looked at during the review

• 🟢 Functionality: all looks good
• 🟢 General issues: all looks good
• 🔴 Security: 1 blocking issue
• 🟢 Review instructions: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

LangSmith trace

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

invalid