Add Docker Swarm support

[damacus]

• Adds swarm init, join, service & token resources

Signed-off-by: Dan Webb [email protected]

[Copilot]

Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 comment.

Files not reviewed (15)

• .tool-versions: Language not supported
• README.md: Evaluated as low risk
• CHANGELOG.md: Evaluated as low risk
• kitchen.yml: Evaluated as low risk
• .github/workflows/ci.yml: Evaluated as low risk
• kitchen.exec.yml: Evaluated as low risk
• documentation/docker_swarm_service.md: Evaluated as low risk
• test/cookbooks/docker_test/recipes/swarm_default.rb: Evaluated as low risk
• spec/unit/resources/swarm_service_spec.rb: Evaluated as low risk
• documentation/docker_swarm_token.md: Evaluated as low risk
• resources/swarm_init.rb: Evaluated as low risk
• test/cookbooks/docker_test/recipes/swarm_init.rb: Evaluated as low risk
• spec/unit/resources/swarm_join_spec.rb: Evaluated as low risk
• documentation/docker_swarm_init.md: Evaluated as low risk
• resources/swarm_join.rb: Evaluated as low risk

Comments suppressed due to low confidence (2)

resources/swarm_token.rb:25

• [nitpick] The error message could be more descriptive by specifying which token type it failed to get.

raise "Error getting #{token_type} token: #{cmd.stderr}" if cmd.error?

resources/swarm_token.rb:38

• [nitpick] The error message could be more descriptive by specifying which token type it failed to rotate.

raise "Error rotating #{token_type} token: #{cmd.stderr}" if cmd.error?

[Stromweld]

github actions flagged your matrix of OS's as missing 2 spaces in the indentation in your ci.yaml file causing the yaml lint job to fail.

[Copilot]

Copilot reviewed 15 out of 30 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

• .tool-versions: Language not supported
• README.md: Evaluated as low risk
• CHANGELOG.md: Evaluated as low risk
• resources/installation_package.rb: Evaluated as low risk
• kitchen.yml: Evaluated as low risk
• kitchen.exec.yml: Evaluated as low risk
• .github/workflows/ci.yml: Evaluated as low risk
• resources/swarm_join.rb: Evaluated as low risk
• documentation/docker_swarm_token.md: Evaluated as low risk
• resources/swarm_init.rb: Evaluated as low risk
• documentation/docker_swarm_service.md: Evaluated as low risk
• documentation/docker_swarm_init.md: Evaluated as low risk
• libraries/helpers_swarm.rb: Evaluated as low risk
• lefthook.yml: Evaluated as low risk
• documentation/docker_swarm_join.md: Evaluated as low risk

Comments suppressed due to low confidence (2)

.github/actions/chef-install/action.yml:41

• The format function is not available in PowerShell by default. Use string interpolation instead: -version ${inputs.version}.

install -channel ${{ inputs.channel }} -project ${{ inputs.project }} ${{ inputs.version && format('-version {0}', inputs.version) }}

.github/actions/test-kitchen/action.yml:25

• [nitpick] The default value for 'kitchen-command' is set to 'test'. Ensure this default value is appropriate for all scenarios where this action might be used.

default: 'test'

[Copilot]

The variable name 'licence' is a typo. It should be 'license'.

Suggested change

	curl -L "https://trial-acceptance.downloads.chef.co/install.sh?license_id=#${{ env.licence }}" | sudo bash -s -- -P chef
	curl -L "https://trial-acceptance.downloads.chef.co/install.sh?license_id=#${{ env.license }}" | sudo bash -s -- -P chef

[Copilot]

The method service_exists? is defined twice, once in the libraries/helpers_swarm.rb file and once in the action_class of the docker_swarm_service resource. Remove the redundant definition from the action_class and use the one from the libraries/helpers_swarm.rb file.

Suggested change

	def service_exists?(new_resource)
	# def service_exists?(new_resource)