Fixed: missing default protocol when using dest_port property

Signed-off-by: Joseph Larionov <[email protected]>
sous-chefs · Jan 27, 2025 · 18146dd · 18146dd
1 parent dadb305
commit 18146dd
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ This file is used to list changes made in each version of the firewall cookbook.
 
 ## Unreleased
 
+### Fixed
+
+- `firewall_rule` doesn't default protocol to `tcp` when using `dest_port` property.
+
 ## 7.0.0 - *2025-01-03*
 
 ### Summary

diff --git a/resources/firewall_rule_firewalld.rb b/resources/firewall_rule_firewalld.rb
@@ -45,7 +45,7 @@
     deny: :drop,
   }
 
-  protocol_required = property_is_set?(:protocol) || property_is_set?(:port) | property_is_set?(:source_port)
+  protocol_required = property_is_set?(:protocol) || property_is_set?(:port) | property_is_set?(:dest_port) | property_is_set?(:source_port)
   array_property = check_for_port_array_property(new_resource)
 
   if array_property

diff --git a/test/fixtures/cookbooks/firewall-test/recipes/default.rb b/test/fixtures/cookbooks/firewall-test/recipes/default.rb
@@ -37,6 +37,16 @@
   command :allow
 end
 
+firewall_rule 'dest_port' do
+  dest_port 25
+  command :allow
+end
+
+firewall_rule 'source_port' do
+  source_port 31000
+  command :allow
+end
+
 # other rules
 firewall_rule 'temp1' do
   port 1234